Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] Remove the use of dmlc parsers #290

Merged
merged 2 commits into from
Jul 10, 2021

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jul 9, 2021

Extracted from #285.

  • Do not use dmlc/data.h.
  • [Breaking] Drop support for loaindg DMatrix from text files in LIBSVM or CSV format. Users are asked to use 3rd-party libraries such as NumPy, Pandas, and scikit-learn to load data from text files. The C API function TreeliteDMatrixCreateFromFile is removed.
  • Python tests now require scikit-learn package, in order to load test data from LIBSVM files.

This commit REMOVES the ability for DMatrix to load data from text
files.
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #290 (79dbbbc) into mainline (5329e85) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #290      +/-   ##
==============================================
- Coverage       84.78%   84.77%   -0.02%     
  Complexity         46       46              
==============================================
  Files             102      102              
  Lines            7902     7821      -81     
  Branches           50       50              
==============================================
- Hits             6700     6630      -70     
+ Misses           1177     1166      -11     
  Partials           25       25              
Impacted Files Coverage Δ
include/treelite/data.h 100.00% <ø> (+16.66%) ⬆️
include/treelite/predictor.h 92.30% <ø> (ø)
python/treelite/util.py 83.87% <ø> (+2.78%) ⬆️
runtime/python/treelite_runtime/predictor.py 85.86% <0.00%> (-0.77%) ⬇️
src/annotator.cc 90.74% <ø> (ø)
src/c_api/c_api.cc 96.65% <ø> (ø)
src/c_api/c_api_common.cc 100.00% <ø> (ø)
src/compiler/ast_native.cc 96.08% <ø> (ø)
src/data.cc 80.76% <ø> (-2.18%) ⬇️
src/gtil/predict.cc 85.50% <ø> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5329e85...79dbbbc. Read the comment docs.

@hcho3 hcho3 merged commit f769f5b into dmlc:mainline Jul 10, 2021
@hcho3 hcho3 deleted the remove_dmlc_parsers branch July 10, 2021 09:17
@hcho3 hcho3 mentioned this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants