-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev Test: Beer's Law Lab 1.7.0-dev.8 #889
Comments
PSA for QA: The dev version was published before examples.md was created, so it does not appear on the Wrapper Index Page and any link you find to it will appear broken. However, it now exists here: Please review it how you normally would. |
@KatieWoe I do not see the heap size decreasing in the above snapshots. That's indicative of a slow memory leak, but I see that you did not create a GitHub issue. Could you please run a longer test, to verify that heap size does go down at some point? And if it does NOT go down, please create an issue. |
Mea culpa. In Slack#quality-assurance, @samreid pointed out that:
And actually 3 => 4 goes down in both brands. So no need to test further. |
Is "going down" between snapshots the only metric for a lack of a memory leak? There are many sims with a plethora of dynamic elements (like Number Play cards, or potentially BLL particles), where snapshot one may have 10,000 particles in the running sim, and then snapshot two only has 5,000. I wouldn't want QA to get the idea that a decrease in heap size between those two snapshots eliminates the possibility of a slower memory leak. That said, it has never been clear to me what QA's role is specifically in identifying memory leaks, perhaps only the outrageous ones are worth their time. |
When I'm deciding to make an issue, I'm looking for the footprints too be under 100 MB, and to plateau in growth. Going down in between snapshots is generally a good metric for that. However, if it's growing otherwise I would still make an issue. In general, QA's roll is to do the measurements, and if I can clearly see a problem I make an issue. Otherwise, I leave the results of the test in a comment for the developer to look over, in case there is a problem that I missed. |
Calling QA here |
Issues addressed, RCs published, we will continue in the RC test. |
Dev Test
Mentions: @Nancy-Salpepi @KatieWoe @kathy-phet @pixelzoom @stemilymill @zepumph @samreid @arouinfar
Publication of this sim is being generally tracked in phetsims/beers-law-lab#300
Note 1: Beer's Law Lab supports dynamic locale
Note 2: This sim does not support migration and this sim does not need to account for migration rules
Simulation links
Test Matrix
Please include all (non-screen reader) feature testing in these records if applicable.
Light testing, or optionally skip if time crunch:
If PhET-iO is being tested:
Features included
For QA...
General features
What to Test
PhET-iO features
What to Test
sure the simulation loads without crashing or throwing errors.
Accessibility features
What to Test
Specific instructions can be found above.
Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:
Test all possible forms of input.
Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.
Platforms and Screen Readers to Be Tested
Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.
Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.
FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.
How should I format my issue?
Here's a template for making issues:
Who should I assign?
We typically assign the developer who opened the issue in the QA repository.
My question isn't in here... What should I do?
You should:
The text was updated successfully, but these errors were encountered: