-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect pointer areas for Solute radio buttons #317
Comments
This is due to a bug in AquaRadioButtonGroup. It's doing the wrong thing for horizontal orientation. See phetsims/sun#825. |
phetsims/sun#825 has been addressed. And in the above commit, I tweaked the pointer areas for this specific case. See screenshot below. @KatieWoe please review in master, close if OK. |
Looks good in master |
For phetsims/qa#894: |
Hmmm... The fix was made and confirmed in master during a dev test, so there was no release branch to cherry-pick to. I'll investigate... |
This is definitely still fixed in master. I wasn't involved in creating the 1.7 release branches, but something is very wrong. I've reopened all of the issues that I addressed during dev testing, to confirm whether they are fixed in 1.7.0-rc.1. Assigning to @samreid @matthew-blackman to investigate what went wrong here. |
@KatieWoe @Nancy-Salpepi please reconfirm in 1.7.0-rc.2 for phetsims/qa#894 and phetsims/qa#895. |
This is fixed in 1.7.0-rc.2. It looks like the screenshot in #317 (comment) |
Test device
Dell
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#889. Not seen in published
The pointer area for the solids shaker extends beyond the toolbox, which leads to slightly odd behavior, where you can click outside the toolbox and still select the shaker. This is mor a concern for the mouse area rather than the touch area.
Some locales have this issue with the dropper as well.
Visuals
Troubleshooting information:
!!!!! DO NOT EDIT !!!!!
Name: Beer's Law Lab
URL: https://phet-dev.colorado.edu/html/beers-law-lab/1.7.0-dev.8/phet/beers-law-lab_all_phet.html?showPointerAreas
Version: 1.7.0-dev.8 2023-01-27 19:51:37 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36
Language: en-US
Window: 1280x649
Pixel Ratio: 1.5/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}
The text was updated successfully, but these errors were encountered: