Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio may be unable to load when preferences are changed #321

Closed
KatieWoe opened this issue Feb 1, 2023 · 7 comments
Closed

Studio may be unable to load when preferences are changed #321

KatieWoe opened this issue Feb 1, 2023 · 7 comments

Comments

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 1, 2023

Device
Dell
OS
Win 11
Browser
Chrome and Firefox
Problem Description
For phetsims/qa#889 and phetsims/qa#891.
When loading a sim set up in studio, if there has been a change with the show volume or show solute amount checkboxes in the preferences menu, either in the saved sim or the sim while trying to load, studio will crash with the error shown below. Studio also does not load again even after refreshing. A new tab must be opened.
Steps to Reproduce

  1. Save a version of the sim in studio
  2. Turn on show volume
  3. Try to load the saved sim

Visuals
loadfile

@pixelzoom
Copy link
Contributor

Sounds like something is missing from dispose. Probably Text for some control(s). I'm on it.

1 similar comment
@pixelzoom
Copy link
Contributor

Sounds like something is missing from dispose. Probably Text for some control(s). I'm on it.

@pixelzoom
Copy link
Contributor

Fixed in the above commits. Tested using the above "Steps to Reproduce".

@KatieWoe please verify in master, feel free to close if OK.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Feb 1, 2023

Looks good in master

@KatieWoe KatieWoe closed this as completed Feb 1, 2023
@pixelzoom
Copy link
Contributor

Reopening to confirm in phetsims/qa#894. It looks like changes I made during dev testing did not get into the 1.7 release branch.

@KatieWoe can you please test to see if this looks correct in 1.7.0-rc.1.

@samreid @matthew-blackman FYI.

@pixelzoom pixelzoom reopened this Feb 6, 2023
@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 8, 2023

@KatieWoe @Nancy-Salpepi please reconfirm in 1.7.0-rc.2 for phetsims/qa#894 and phetsims/qa#895.

@Nancy-Salpepi
Copy link

This is fixed in 1.7.0-rc.2 for BLL and Concentration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants