-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing tandems for Text/RichText elements #314
Comments
Confirmed with @arouinfar that the above need to be instrumented. These do NOT need to be instrumented:
|
These:
... turned out to be instrumented, but incorrectly named. I changed the tandem name from 'labelText' to 'text', to match the pattern used for other radio buttons. |
Over to @arouinfar to review. Let me know if you want to feature any of these. Feel free to close if no further changes are needed. |
Thanks @pixelzoom. Everything looks good in master. The contents of |
Reopening to confirm that these changes made it into 1.7 release branch. |
Confirmed that this change is present in 1.7. Closing. |
For phetsims/qa#889
Reviewing #312 resulted in me identifying some Text/RichText elements that are not instrumented, along with a couple of other misc. things.
The tandems that I believe are missing are:
Text elements:
I'd like to confirm with @arouinfar before I instrument these.
The text was updated successfully, but these errors were encountered: