Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beer's Law Lab - Publish 1.7.0 with PhET-iO upgrades #300

Closed
pixelzoom opened this issue Dec 16, 2022 · 10 comments
Closed

Beer's Law Lab - Publish 1.7.0 with PhET-iO upgrades #300

pixelzoom opened this issue Dec 16, 2022 · 10 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Dec 16, 2022

@arouinfar @kathy-phet FYI.

This also includes Concentration. Note that Concentration version number should be brought forward to 1.7.

@pixelzoom
Copy link
Contributor Author

Unassigning, because it looks like it will be awhile before we're ready to begin the release process.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jan 31, 2023

@matthew-blackman and team phettuccine. This is the kind of comment I'm anticipating will be added to this issue when a test is added to the QA Pipeline.


1/27/2023 1.7.0-dev.8 (full) testing begins, brands=phet,phet-io.

beers-law-lab:

concentration:

@samreid
Copy link
Member

samreid commented Feb 3, 2023

2/3/2022: We are ready to create the RC. brands=phet,phet-io. @matthew-blackman and I will do so for this sim and concentration. We will makes sure they have the same major.minor version.

During our 1st attempt, we hit lint errors in perennial-alias:

/Users/samreid/apache-document-root/main/perennial-alias/js/build-server/build-server.js
   23:1   error  Mismatched require statement values, persistentQueue !== persistentQueue.js  require-statement-match
  291:15  error  'task' is never reassigned. Use 'const' instead                              prefer-const

/Users/samreid/apache-document-root/main/perennial-alias/js/build-server/persistentQueue.js
   4:1   error  Mismatched require statement values, _ !== lodash  require-statement-match
  44:21  error  Unexpected trailing comma                          comma-dangle

/Users/samreid/apache-document-root/main/perennial-alias/js/build-server/taskWorker.js
  22:1  error  Mismatched require statement values, persistentQueue !== persistentQueue.js  require-statement-match

✖ 5 problems (5 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.


Fatal error: Lint failed

@samreid
Copy link
Member

samreid commented Feb 3, 2023

Deployed: https://phet-dev.colorado.edu/html/beers-law-lab/1.7.0-rc.1/phet/beers-law-lab_en_phet.html
Deployed: https://phet-dev.colorado.edu/html/beers-law-lab/1.7.0-rc.1/phet-io/
Please wait for the build-server to complete the deployment, and then test!

I'll do concentration next.

UPDATE:
Deployed: https://phet-dev.colorado.edu/html/concentration/1.7.0-rc.1/phet/concentration_en_phet.html
Deployed: https://phet-dev.colorado.edu/html/concentration/1.7.0-rc.1/phet-io/
Please wait for the build-server to complete the deployment, and then test!

@matthew-blackman can you please spend a few minutes sanity testing those links, then if all seems well, please create the RC issues in the qa repo?

@matthew-blackman
Copy link

matthew-blackman commented Feb 3, 2023

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 17, 2023

2/6/2023 Due to problems with the 1.7 shas, testing of 1.7.0-rc.1 was stopped before completing. 1.7.0-rc.2 was published, the QA issues for 1.7.0-rc.1 were (unfortunately) renamed to 1.7.0-rc.2, and tesitng resumed. Here are the QA issues and dev versions:

beers-law-lab:

concentration:

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 17, 2023

2/15/2023: 1.7.0-rc.2 testing was completed .

All issues have been addressed, but a patch for a common-code problem is needed; see #329.

An additional RC spot-check will be needed.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 17, 2023

@pixelzoom
Copy link
Contributor Author

2/17/2023 1.7.0-rc.3 testing completed. All issues vertified, and no new issues were found. I'll proceed with publishing.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Feb 17, 2023

2/17/2023: 1.7.0 was published.

Metrics:

  • 20 days elapsed for QA process
  • 1 dev test, 2 RC tests
  • 10 PhET-iO issues, 4 dynamic-locale issues, 1 general issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants