Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag interactions aren't interrupted with Reset All on the iPad #316

Closed
Nancy-Salpepi opened this issue Jan 31, 2023 · 4 comments
Closed

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Jan 31, 2023

Test device
ipad 9th generation

Operating System
16.2

Browser
safari

Problem description
For phetsims/qa#889 and phetsims/qa#891, pressing Reset All does not interrupt me holding an object with another finger. This happens with the following items on the Concentration Screen: the faucet, shaker, evaporation slider, and concentration probe. On the Beer's Law screen: the ruler, probe, concentration slider, and cuvette arrow.

Also seen in published.

Steps to reproduce
Here is an example:

  1. On the iPad, on the Concentration screen, move and hold the Concentration Probe with one finger
  2. With another finger, press the Reset All button
  3. Wiggle your first finger slightly--the probe will move back to that position

Visuals

IMG_7847.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Laboratoire Loi de Beer-Lambert‬ URL: https://phet-dev.colorado.edu/html/beers-law-lab/1.7.0-dev.8/phet/beers-law-lab_all_phet.html Version: 1.7.0-dev.8 2023-01-27 19:51:37 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36 Language: en-US Window: 1536x781 Pixel Ratio: 1.7999999523162842/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@pixelzoom
Copy link
Contributor

Fixed in master. @Nancy-Salpepi please review and close if OK.

@Nancy-Salpepi
Copy link
Author

Looks good in master. Closing.

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 6, 2023

Reopening to confirm in phetsims/qa#894. It looks like changes I made during dev testing did not get into the 1.7 release branch.

@samreid @matthew-blackman FYI.

@pixelzoom pixelzoom reopened this Feb 6, 2023
@pixelzoom
Copy link
Contributor

Confirmed that this change is in 1.7, inspect code. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants