-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should dropper have a fixed position? #323
Comments
Yes, let's fix the position of the dropper @pixelzoom. In case someone in the future questions this decision, the many reasons why the movable dropper was problematic in ph-scale are documented here: phetsims/ph-scale#270 (comment) |
Next questions is where should the fixed position of the dropper be? The default when you start the sim is the first screenshot below. I have a slight aesthetic preference for centering it between the faucet and right edge of the beaker, second screenshot below -- @arouinfar is that OK with you? |
Centered looks good to me @pixelzoom. |
Done in the above commit. @arouinfar please have a look in master, close if OK. I'm glad we're doing this for the first version of the sims to have API files, so we don't need a migration rule. |
Looks good, thanks! |
Reopening to confirm in phetsims/qa#894. It looks like changes I made during dev testing did not get into the 1.7 release branch. |
Still OK in 1.7 branch. Closing. |
Related to phetsims/qa#889.
This sim has all of the same problem with the movable dropper that we encountered in phetsims/ph-scale#270. Should we make the dropper also have a fixed position in this sim? Or is this sim somehow different because the shaker is (necessarily) movable?
My preference would be to also make the dropper have a fixed position here. Otherwise we'll be circling back to this when the sim gets alt input support.
The text was updated successfully, but these errors were encountered: