Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should ruler position have bounds? #322

Closed
stemilymill opened this issue Feb 1, 2023 · 2 comments
Closed

Should ruler position have bounds? #322

stemilymill opened this issue Feb 1, 2023 · 2 comments

Comments

@stemilymill
Copy link

For phetsims/qa#889

beersLawLab.beersLawScreen.model.ruler.positionProperty can be set using setValue to positions far outside dev bounds.

If the window size is manipulated such that the ruler becomes visible, clicking on the ruler will return it to default position.

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 1, 2023

My recommendation is to close this issue as "won't fix". Over in phetsims/ph-scale#270 (comment), we concluded that, for movable things that have drag bounds, we're not going to prevent the PhET-iO client from positioning them outside their drag bounds. It doesn't hurt the sim, and the movable thing (ruler in this case) will snap into the drag bounds as soon as the student starts dragging it. If they position it outside the bounds of the browser so that it's not visible/draggable -- well, don't do that.

@arouinfar if you agree, please close. Otherwise let me know what you'd like to do.

@arouinfar
Copy link
Contributor

Completely agree @pixelzoom, closing as wont-fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants