Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhET-iO: Should we validate the positions of the objects or put bounds. #454

Closed
veillette opened this issue Apr 18, 2023 · 3 comments
Closed
Assignees

Comments

@veillette
Copy link
Contributor

image

In PhET-IO we can set the position of the arrowObject such that it ends up on the right side of the lens. This is not possible do to by dragging the object and the simulation makes an assumption that the object is always to the left of the lens, so it lead to erroneous result.

While discussing with @arouinfar, she mentioned that this has been noted in other sims, for instance, phetsims/beers-law-lab#322 and phetsims/ph-scale#270 . Often the solution has been to document it properly in examles.md such as
https://github.com/phetsims/phet-io-sim-specific/blob/master/repos/beers-law-lab/examples.md#fix-the-position-of-the-concentration-probe-to-the-bottom-of-the-beaker.

However, here the position of the framedObject seem to have some form of position validation that the arrowObject does not have so it me be worth investigating if it is possible to validate the position of the objects.

@veillette veillette self-assigned this Apr 18, 2023
@pixelzoom
Copy link
Contributor

This has come up numerous times in the context of other sims. The solution has been to document in example.md. I recommend we do the same here. I see little value for the effort involved in trying to prevent the designer from putting things in "bad" positions.

@pixelzoom pixelzoom changed the title PhET-IO: Should we validate the positions of the objects or put bounds. PhET-iO: Should we validate the positions of the objects or put bounds. Apr 19, 2023
@pixelzoom
Copy link
Contributor

My recommendation is to do nothing for this issue, see #454 (comment). Assigning to @arouinfar to decide how to proceed.

@arouinfar
Copy link
Contributor

I agree @pixelzoom, let's close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants