Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should there be a range or error message when changing positionProperty values? #464

Closed
Nancy-Salpepi opened this issue May 10, 2023 · 1 comment
Assignees
Labels
type:question Further information is requested

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
13.3.1

Browser
Safari

Problem description
For phetsims/qa#938, I am noticing 2 odd things in studio when using the 'get value' 'set value' buttons for positionProperty:

  1. For lensScreen.model.scenes.arrowScene.arrowObject1.positionProperty, I am able to enter a positive x value which moves the arrow to the right side of the lens. Once I either try to move the arrow, or launch the sim, the x value changes to -40.

  2. For lensScreen.model.scenes.framedScene.framedObject.positionProperty, if I enter a value larger than -40, the object is placed at x= -40. The same is true for the lightScene. I was wondering if an error message should pop up or if a range should be given here?

Steps to reproduce

  1. In studio, go to lensScreen.model.scenes.arrowScene.arrowObject1.positionProperty and press 'get value'
  2. Change the value of x to a positive number. Press 'set value'
  3. Try to move the arrow
  4. Repeat steps with lensScreen.model.scenes.framedScene.framedObject.positionProperty

Visuals
Screenshot 2023-05-10 at 1 52 56 PM

@Nancy-Salpepi Nancy-Salpepi added the type:question Further information is requested label May 10, 2023
@arouinfar
Copy link
Contributor

Thanks @Nancy-Salpepi. This came up in #454 (and other sims linked in that issue too) and we decided to do nothing. Validating positionProperty is far more complicated than validating a simple number like diameterProperty. In examples.md, we recommend that clients set the desired position by interacting with the simulation and using "Get Command".

@arouinfar arouinfar closed this as not planned Won't fix, can't repro, duplicate, stale May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants