10.2 - Changelog Test Results - Fixed

[individual-it]

Part of #35020

Fixed

• Wrong translation file referenced for accept & decline share - #35063 - @individual-it
• Respect 'writable' appdir flag on update - #35097 - @individual-it
• Fix regression with missing progress bar in files drop view - #35059 - @individual-it
• Log exception when background job class not found - #34723 @paurakhsharma
• Prevent concurrent updates in group shares to avoid duplicate entries - #34769 🤖 - see 10.2 - Changelog Test Results - Fixed #35054 (comment)
• Calender invitation now uses actual sender name - [[stable10] invitation sender name from master to stable10 #34901] ([stable10] invitation sender name from master to stable10 #34901) @paurakhsharma
• Fix public link share default expiration behavior - #34971 @skshetry
• Improve files error handling on download - #34886 - @individual-it
• Directly honour robots.txt if htaccess.RewriteBase is set - #34949 - @individual-it
• Reduce sharing query size by properly reusing the query builder - #34915 🤖 CI and smoke-test
• Tar download support for file names longer than 99 chars - #34615 @skshetry
• Fix Webdav error page, include CSP and message - #34817 - @individual-it
• Handle accept decline with invalid share id - #34786 - @dpakach
• Normalize path when moving chunks to final destination - #34777 🤖 (admin_audit)
• Better support for international email addresses after swiftmailer update - #34759 @paurakhsharma
• Fix first time login handling - #34758 @DeepDiver1975
• Server container interface should inherit from icontainer,… - #34756 🤖
• Don't expose hashed password in OCS api - #34691 - share_with="redacted" now - @PVince81
• Fixes UID issue with birthday calendar events - #34701 @paurakhsharma
• Improve avatar performance by having many avatar related calls bypass the file cache - #34592 @paurakhsharma
• Improve speed of apps list settings page by caching integrity check results - #34584 @skshetry
• Fix chunking infinite loop in some environment related issues - #34558 @skshetry
• Fixes issue file picker choose button disabled for directory selection - #34426 @paurakhsharma
• Use sabre/vobject ^4.2 to fix issues in ITip messages - #34553 @paurakhsharma
• Filter static tags when searching files by tag - #34557 @skshetry
• Fix collaborative tags PHP API for get and create operations - #34610 - hope 🤖 would have caught any issue
• Improve performance of account sync service - #34546 🤖 (in LDAP)
• Improve code occ files_external:list --short - #34549 @skshetry
• Fix preview expiration issues with trashbin/versions - #34533 @paurakhsharma
• Use the displayname in lost password emails where possible - #34512 @paurakhsharma
• Store quota overrides in preferences table - #34467 @dpakach
• Prevent password removal in share dialog if enforced - #34497 @skshetry
• Encryption now skips shared files when adding recovery key - #34506 @sharidas
• Fix encryption to use API instead of config access - #34504 @paurakhsharma
• Properly handle StorageNotAvailableException in Webdav endpoint - #34485 - @individual-it
• Properly hide share fields in "Shared with You" section when permissions are restricted - #34473 @paurakhsharma
• Repair subshares earlier to avoid errors - #34462 - ❌ No way to reproduce @skshetry
• Only parse info.xml once to improve performance for every request - #34482 - smoke tests enable/disable/use various apps @individual-it
• Catch errors when info.xml is malformed - #34427 @paurakhsharma
• Send OCM requests as JSON - #34424 - @dpakach
• Remove composer that is now in vendor bin - #34418 - related to CI test tooling moving to vendor-bin, CI still passes @phil-davis
• Use recipient language when sending notification email - #34255 @paurakhsharma
• Fix shares not accessible for guest users when using "share_folder" config option - #34395 @skshetry
• Fix reset confirmation mail from occ - #34154 @skshetry
• Correctly write Login failed entry in log when 2FA is enforced - #34055 @skshetry
• Center the logo and login fields - #34057 @skshetry
• Fix Apache warnings by setting headers to "always" in htaccess - #34089 - 🚫 - raised header set twice in 4xx responses #35093 - fixed in RC2 #35118 - @individual-it
• Fix external storage advanced checkbox state issue - #34168 @skshetry
• Set permissions on log file creation instead of every write - #34061 - @individual-it
• Images are again properly rotated now based on EXIF rotation - [[stable10] Backport of Use loadFromFile instead of loadFromFileHandle #34356] ([stable10] Backport of Use loadFromFile instead of loadFromFileHandle #34356) @paurakhsharma
• Fix query parts for federated shares to be less expensive - #34401 - 🤖
• Fix cancel upload and hide 'uploading' message for files_drop shared folders - #34097 🚫 raised File upload on files_drop does not abort if tried to cancel after waiting for few seconds #35086 - fixed in RC2 #35134 - @skshetry

[skshetry]

#34971
Location of "Expire after" changed from 10.1.1 which was as below:

And, when expiration date is unenforced and default share is removed on public link share, no expiration date is set.

[skshetry]

Regarding #34097:

Canceling upload in files_drop did not work correctly if it is canceled after waiting for a few sec. But, this does work if it is canceled immediately (which didn't work on v10.1.1). The uploading message does disappear after the file is uploaded.

See test video here: https://cloud.owncloud.com/index.php/s/1psr6GzChn3u83L

EDIT: Issue created here: #35086

[paurakhsharma]

Regarding #34427
I the exception is shown in the log but I am not sure if it is the expected error message.(according to this PR)

These are the steps I followed.

1. Change appinfo.xml to an invalid XML
2. Run the command ./occ app:check-code <app_name>
3. I see an InvalidArgumentException\ thrown in owncloud.log with message Could not convert XML to array (which is expected)

But, I cannot produce an error with the message as in https://github.com/owncloud/core/pull/30457/files#diff-1e7169b61c01f1c8a31c364b3a217135R128
How do I produce such a message?

Note I am marking this fix as checked as I was able to produce InvalidArgumentException in the log

[skshetry]

Fix chunking infinite loop in some environment-related issues was tested using the How this has been tested section in #34489

[individual-it]

after #34089 headers can be set twice in 4xx responses if already defined in apache config - raised #35093

[sharidas]

I have verified #34506 with 10.2.0 RC1.
Verified it by by creating a local share within oC users and enabled recovery key for the recipient of share user. Used debugger to verify the recovery keys are not added for recipient share user.

[patrickjahns]

I see the following open points:

• Store quota overrides in preferences table - [stable10] Store quota overrides in preferences table #34467
• Prevent concurrent updates in group shares to avoid duplicate entries - [stable10] Protect group share concurrent updates with upsert #34769

I believe #34769 was agreed that this can not be manually confirmed and is fine - what about #34467 ?

[skshetry]

Repair subshares earlier to avoid errors - #34462 - was also skipped as it cannot be reproduced (as per the discussion).

[PVince81]

For "Prevent concurrent updates in group shares to avoid duplicate entries - #34769" we should check that we have acceptance tests that cover the general cases with subshares (but not this one specific case about duplicates). There is already some coverage on unit test level but would be good to have some on higher level.

[PVince81]

for "Store quota overrides in preferences table - #34467" it is likely that LDAP will be required.
manual test would be fine for RC but consider automating it as part of owncloud/user_ldap#368 (comment)

[individual-it]

updated the list above with changes in RC2 listed in e801e4e

[individual-it]

I think we are done here for now
list for tests to be automated here #35207