Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] fixes issue file picker choose button disabled for directory selectiom #34426

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Feb 8, 2019

Backport of #33181 to stable10

Please review @felixheidecke

@PVince81 PVince81 added this to the development milestone Feb 8, 2019
@PVince81 PVince81 self-assigned this Feb 8, 2019
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34426 into stable10 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34426      +/-   ##
==============================================
- Coverage        63.5%    63.5%   -0.01%     
  Complexity      19140    19140              
==============================================
  Files            1265     1265              
  Lines           75297    75299       +2     
  Branches         1291     1292       +1     
==============================================
  Hits            47817    47817              
- Misses          27100    27102       +2     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.31% <0%> (-0.02%) 0 <0> (ø)
#phpunit 64.59% <ø> (ø) 19140 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/js/oc-dialogs.js 2.66% <0%> (-0.02%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8111a...91c3c05. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34426 into stable10 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34426      +/-   ##
==============================================
- Coverage        63.5%    63.5%   -0.01%     
  Complexity      19140    19140              
==============================================
  Files            1265     1265              
  Lines           75297    75299       +2     
  Branches         1291     1292       +1     
==============================================
  Hits            47817    47817              
- Misses          27100    27102       +2     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.31% <0%> (-0.02%) 0 <0> (ø)
#phpunit 64.59% <ø> (ø) 19140 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/js/oc-dialogs.js 2.66% <0%> (-0.02%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8111a...91c3c05. Read the comment docs.

@PVince81
Copy link
Contributor Author

@felixheidecke quick review ?

@PVince81 PVince81 merged commit ae460dc into stable10 Feb 20, 2019
@PVince81 PVince81 deleted the stable10-filepicker-button branch February 20, 2019 10:33
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants