Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issue file picker choose button disabled for directory selectio… #33181

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

greku
Copy link
Contributor

@greku greku commented Oct 13, 2018

…n #30691

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #33181 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33181      +/-   ##
============================================
- Coverage     64.12%   64.12%   -0.01%     
  Complexity    18720    18720              
============================================
  Files          1184     1184              
  Lines         70437    70439       +2     
  Branches       1270     1271       +1     
============================================
  Hits          45171    45171              
- Misses        24896    24898       +2     
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.88% <0%> (-0.02%) 0 <0> (ø)
#phpunit 65.4% <ø> (ø) 18720 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/js/oc-dialogs.js 2.66% <0%> (-0.02%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623284a...919a996. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

@greku please fill the "how was this tested" section to confirm that you retested this after the change

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2019

stable10: #34426

@lock lock bot locked as resolved and limited conversation to collaborators Feb 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants