Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Always set headers #34089

Merged

Conversation

DeepDiver1975
Copy link
Member

backport #31231

If Apache already set the headers, they will not be defined twice
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #34089 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34089   +/-   ##
===========================================
  Coverage       63.48%   63.48%           
  Complexity      19109    19109           
===========================================
  Files            1264     1264           
  Lines           75147    75147           
  Branches         1286     1286           
===========================================
  Hits            47710    47710           
  Misses          27061    27061           
  Partials          376      376
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.57% <ø> (ø) 19109 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b278a2...49d7ba6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #34089 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34089   +/-   ##
===========================================
  Coverage       63.48%   63.48%           
  Complexity      19109    19109           
===========================================
  Files            1264     1264           
  Lines           75147    75147           
  Branches         1286     1286           
===========================================
  Hits            47710    47710           
  Misses          27061    27061           
  Partials          376      376
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.57% <ø> (ø) 19109 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b278a2...49d7ba6. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

for 10.1.1

@phil-davis phil-davis mentioned this pull request Jan 17, 2019
@phil-davis phil-davis merged commit 8816494 into stable10 Feb 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-5913a848bf527def8bad1d38c041ec2256fceee8 branch February 7, 2019 13:15
@benrubson
Copy link
Contributor

Strangely enough, owncloud-10.1.1.tar.bz2 from https://owncloud.org/download/ does not contain these modifications !

@patrickjahns
Copy link
Contributor

@benrubson
Please see the changelog for 10.1.1 https://github.com/owncloud/core/blob/stable10/CHANGELOG.md#1011

It only contained a single change we deemed critical enough to release 10.1.1

Above PR is stell listed in the unreleased section

@benrubson
Copy link
Contributor

Sorry for having misunderstood this @patrickjahns, and thank you very much for clarification 👍

@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants