Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quota related tests for LDAP users #368

Closed
3 tasks done
dpakach opened this issue Feb 1, 2019 · 4 comments
Closed
3 tasks done

Add quota related tests for LDAP users #368

dpakach opened this issue Feb 1, 2019 · 4 comments

Comments

@dpakach
Copy link
Contributor

dpakach commented Feb 1, 2019

#343 added tests for various user attributes for ldap users usning occ, API and webui.
But there are no tests for changing quota of a LDAP user.

Add tests for checking what can/cannot happen with respect to modifying quota of LDAP users using

  • occ (quota cannot be set by occ command)
  • API
  • webUI

Consider the admin changing quota locally in ownCloud, then sync the user and check that the local "override" of quota is still in effect. LDAP should always have authority. see owncloud/core#32731 (comment)

this means that if LDAP is enabled we should prevent any modification of fields email, avatar, display name or quota if an LDAP attribute is specified for such fields in the config. If no field is specified, allow the admin to set values in the users page.

if we agree on this we can raise a new ticket to make the necessary changes for blocking input for all these fields in the users page, provisioning API and occ commands.

Work out how to "reset" the local override so that the quota from LDAP is used again - test that.

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #193 (Invalid quota <> for LDAP user), #302 (Add more tests to drone), #26 (LDAP Plugin stops after Importing first user), #205 (Transfer users local to users ldap), and #53 (Add tooltips to Quota field and email field).

@phil-davis
Copy link
Contributor

See owncloud/core#34467 for a proposed core change that should make this "quota overriding" work.

@PVince81
Copy link
Contributor

PVince81 commented Apr 26, 2019

@individual-it
Copy link
Member

quota overrides tested in #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants