[stable10] Store quota overrides in preferences table

[tomneedham]

Description

Currently the user management UI in stable10 uses this method, through setquota.php to update the quota of a user. However, if they are from another user backend, on sync the quota is just replaced.

New version of #32731

Setting the quota override should set it in the preferences table as well which is used as the manual override. On sync, the sync serivce checks this and uses this as an override instead. You can delete the key here to go back to the one supplied by the user backend.

Related Issue

#32731

Motivation and Context

Quota is replaced on every sync if you override the quota in owncloud 10 and use an external user backend.

How Has This Been Tested?

Manually in the UI.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[tomneedham]

@pako81 This should solve issues with overriting quotas on sync.

[PVince81]

@tomneedham hmm but wouldn't this code here also overwrite any value that was set by an admin as the override value during the next sync ?

[tomneedham]

No. Sync sets on the account. https://github.com/owncloud/core/blob/master/lib/private/User/SyncService.php#L223

SyncSerice is the connector between the Account and the User Backend.

This convenince method is only used by the provisioning api and the UI to override the user quota that is provided by the user backend.

[PVince81]

Right, I see. So you brought back something we deleted back then.

[PVince81]

I agree with the change, let's see what CI says. I hope we do have some coverage here

[codecov]

Codecov Report

Merging #34467 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable10   #34467      +/-   ##
==============================================
+ Coverage       63.57%   63.57%   +<.01%     
  Complexity      19146    19146              
==============================================
  Files            1265     1265              
  Lines           75314    75315       +1     
  Branches         1291     1291              
==============================================
+ Hits            47884    47885       +1     
  Misses          27050    27050              
  Partials          380      380

Flag	Coverage Δ	Complexity Δ
#javascript	53.32% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.67% <100%> (ø)	19146 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/User/User.php	88.88% <100%> (+0.05%)	73 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1c2c3...fd9df26. Read the comment docs.

[codecov]

Codecov Report

Merging #34467 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable10   #34467      +/-   ##
==============================================
+ Coverage       63.57%   63.57%   +<.01%     
  Complexity      19146    19146              
==============================================
  Files            1265     1265              
  Lines           75314    75315       +1     
  Branches         1291     1291              
==============================================
+ Hits            47884    47885       +1     
  Misses          27050    27050              
  Partials          380      380

Flag	Coverage Δ	Complexity Δ
#javascript	53.32% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.67% <100%> (ø)	19146 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/User/User.php	88.88% <100%> (+0.05%)	73 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f1c2c3...fd9df26. Read the comment docs.

[PVince81]

@individual-it @phil-davis as we have some work regarding LDAP automated tests, we should include something to cover this override

[phil-davis]

@PVince81 @tomneedham looks like testing this was thought about recently: owncloud/user_ldap#368

[PVince81]

ok let's cover that with LDAP then, merging

[PVince81]

👍

[PVince81]

master: #34511

[micbar]

@tom see https://github.com/owncloud/enterprise/issues/2844#issuecomment-493048205

[micbar]

@pmaier1
Carlos re opened the ticket.