Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] server container interface should inherit from icontainer,… #34756

Merged

Conversation

DeepDiver1975
Copy link
Member

… as it is essentially an extended icontainer

backport #32502

@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #34756 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34756      +/-   ##
==============================================
- Coverage       64.19%   64.19%   -0.01%     
  Complexity      19887    19887              
==============================================
  Files            1278     1278              
  Lines           76245    76245              
  Branches         1291     1291              
==============================================
- Hits            48947    48946       -1     
- Misses          26919    26920       +1     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.35% <ø> (-0.01%) 19887 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 86.53% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700efa1...ccfca3b. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit ce4c28c into stable10 Mar 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-d1555ec365fc359d7de447048a731ec58e4b6b52 branch March 13, 2019 15:25
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants