Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Fix visual checkbox issue #34168

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

jvillafanez
Copy link
Member

Description

Backport of #34167 to stable10

Related Issue

https://github.com/owncloud/enterprise/issues/3036

Motivation and Context

How Has This Been Tested?

  1. Mark the checkbox. Reload the page. Make sure the checkbox is checked
  2. Unmark the checkbox. Reload the page. Make sure the checkbox is unchecked
  3. Mark the checkbox again. Reload the page. Make sure the checbox is checked

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@jvillafanez jvillafanez force-pushed the allow_user_mount_sharing_stable10 branch from af3ac8a to 51b5578 Compare January 17, 2019 11:30
@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #34168 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34168   +/-   ##
===========================================
  Coverage       63.48%   63.48%           
  Complexity      19111    19111           
===========================================
  Files            1264     1264           
  Lines           75152    75152           
  Branches         1286     1286           
===========================================
  Hits            47711    47711           
  Misses          27065    27065           
  Partials          376      376
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.57% <ø> (ø) 19111 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/templates/settings.php 32.96% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91d139...51b5578. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #34168 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34168   +/-   ##
===========================================
  Coverage       63.48%   63.48%           
  Complexity      19111    19111           
===========================================
  Files            1264     1264           
  Lines           75152    75152           
  Branches         1286     1286           
===========================================
  Hits            47711    47711           
  Misses          27065    27065           
  Partials          376      376
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.57% <ø> (ø) 19111 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/templates/settings.php 32.96% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91d139...51b5578. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 modified the milestones: QA, development Jan 18, 2019
@phil-davis phil-davis merged commit e7eb5f2 into stable10 Feb 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the allow_user_mount_sharing_stable10 branch February 7, 2019 13:14
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants