v16.10.0 proposal #40175
Merged
v16.10.0 proposal #40175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generators in pipeline must be able to be aborted or pipeline can deadlock. PR-URL: #39067 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
man ld -export_dynamic: ``` Preserves all global symbols in main executables during LTO. Without this option, Link Time Optimization is allowed to inline and remove global functions. This option is used when a main executable may load a plug-in which requires certain symbols from the main executable. ``` Bug: vercel/pkg#1155 Signed-off-by: Jesse Chan <[email protected]> PR-URL: #39839 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #39927 Reviewed-By: James M Snell <[email protected]>
PR-URL: #39957 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #39961 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #39961 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Refs: #33716 Refs: #35993 Refs: #35911 PR-URL: #39972 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
PR-URL: #40003 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
e.g. `wasi` under no `--experimental-wasi-unstable-preview1` flag shouldn't be pre-required. PR-URL: #39942 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
'==' : unsafe mix of type 'bool' and type 'int' in operation PR-URL: #39998 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
It is possible on Windows to configure Git to checkout line-endings "as-is", which for Node.js means Unix-style. This change makes the tests that rely on line endings pass in that case. PR-URL: #40002 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #40004 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Fix indentation, traiiling spaces, and missing newline issues in preparation for linting. PR-URL: #40007 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #40007 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #40007 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #39962 Reviewed-By: James M Snell <[email protected]>
PR-URL: #40029 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #39926 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #40015 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
In two places, we call `Isolate::GetCurrent()` even though that is technically invalid usage of the function. Now that V8 exposes `Isolate::TryGetCurrent()`, we can do this in a proper way. PR-URL: #39954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
This reverts commit 1fc4d43. PR-URL: #39954 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #40019 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
The standard property names that aren't strings can be used where appropiate, this is one of them. PR-URL: #39981 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
[email protected] is out with a fix. |
richardlau
approved these changes
Sep 22, 2021
|
Those |
|
Trying a run on v16.9.1 - https://ci.nodejs.org/job/node-test-commit-linux/nodes=fedora-last-latest-x64/43050/ |
|
I have rebooted both PR-URL needs to be updated in the release commit message. |
Notable changes: crypto: * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927 doc: * add Ayase-252 to collaborators (Qingyu Deng) #40078 fs: * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013 http: * (SEMVER-MINOR) limit requests per connection (Artur K) #40082 src: * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754 * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754 * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926 stream: * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067 PR-URL: #40175
BethGriggs
force-pushed
the
v16.10.0-proposal
branch
from
10b4fe1
to
aff2a0a
Compare
|
Release build on aff2a0a: https://ci-release.nodejs.org/job/iojs+release/7196 |
BethGriggs
added a commit
that referenced
this pull request
Sep 22, 2021
Notable changes: crypto: * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927 doc: * add Ayase-252 to collaborators (Qingyu Deng) #40078 fs: * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013 http: * (SEMVER-MINOR) limit requests per connection (Artur K) #40082 src: * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754 * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754 * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926 stream: * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067 PR-URL: #40175
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Sep 22, 2021
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Sep 22, 2021
18 tasks
This was referenced Sep 24, 2021
This was referenced Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-09-22, Version 16.10.0 (Current), @BethGriggs
Notable Changes
fb226ff2ee] - (SEMVER-MINOR) crypto: add rsa-pss keygen parameters (Filip Skokan) #3992785206b7311] - deps: upgrade npm to 7.24.0 (npm team) #4016798f56d179c] - deps: update Acorn to v8.5.0 (Michaël Zasso) #400159655329772] - doc: add Ayase-252 to collaborators (Qingyu Deng) #4007859fff925be] - (SEMVER-MINOR) fs: makeopenandclosestream override optional when unused (Antoine du Hamel) #40013a63a4bce90] - (SEMVER-MINOR) http: limit requests per connection (Artur K) #40082server.maxRequestsPerSocket.9a672961fa] - (SEMVER-MINOR) src: add --no-global-search-paths cli option (Cheng Zhao) #39754--no-global-search-pathscommand-line option to not search modules from global paths like$HOME/.node_modulesand$NODE_PATH.fe920b6cbf] - (SEMVER-MINOR) src: make napi_create_reference accept symbol (JckXia) #3992697f3072ceb] - (SEMVER-MINOR) stream: add signal support to pipeline generators (Robert Nagy) #39067Commits
b7dc651884] - build: run modified internet tests on GitHub Actions (Rich Trott) #401008d5787a043] - build: add .mailmap/AUTHORS to paths-ignore for test-macos (Rich Trott) #401099793e7ff08] - build: add .mailmap/AUTHORS to path-ignore for test-asan (Rich Trott) #40109886921de38] - build: add paths-ignore for build-tarball workflow (Rich Trott) #4010901b1946b38] - build: only lint version numbers for pull requests (Michaël Zasso) #40027c804d070a6] - build: add daily/on-demand internet test workflow (Rich Trott) #400867bddaecbf4] - build: add YAML linting to GitHub Actions (Rich Trott) #400075a20f9055c] - build: add YAML linting (Rich Trott) #400070b30867c08] - build: run AUTHORS update weekly (Rich Trott) #4000422a78a75ee] - build: preserves symbols during LTO with macOS linker (Jesse Chan) #39839f0dec58d43] - crypto: fix webcrypto ed(25519|448) spki/pkcs8 import (Filip Skokan) #40131d80082f3eb] - crypto: usevalidateObject(Voltrex) #39872d657ae6f8a] - crypto: fix RSA-PSS default saltLength (Tobias Nießen) #39999fc45cbe7a8] - crypto: fix default MGF1 hash for OpenSSL 3 (Tobias Nießen) #40031105c9e6d3b] - crypto: check webcrypto asymmetric key types during importKey (Filip Skokan) #39962fb226ff2ee] - (SEMVER-MINOR) crypto: add rsa-pss keygen parameters (Filip Skokan) #3992785206b7311] - deps: upgrade npm to 7.24.0 (npm team) #4016706f6e01f37] - deps: add riscv64 into openssl Makefile and gen openssl-riscv64 (Lu Yahan) #400639c76c69972] - deps: patch V8 to 9.3.345.19 (Michaël Zasso) #401080df47d5843] - deps: upgrade npm to 7.23.0 (npm team) #40055b3843bf417] - deps: patch v8 for vs2019 in std17 (Jiawen Geng) #4006067759585a0] - deps: patch for v8 on windows (Jiawen Geng) #4001098f56d179c] - deps: update Acorn to v8.5.0 (Michaël Zasso) #400155c6708582e] - dns: cleanup validation (Voltrex) #40061e4825dcfd5] - doc: changes default values for fs.read fns (RISHABH BUDHIRAJA) #391630254b4b0d3] - doc: fix markdown indentation in lists (Michaël Zasso) #40142b6939a3419] - doc: prepare README.md for stricter linting (Rich Trott) #40137a07d8444f9] - doc: fix comma splice (Rich Trott) #401332488bc0c4f] - doc: clean up weird notes about reentrancy (Anna Henningsen) #401078b80dcbc30] - doc: correct parameters in fs and stream documentation (vipul kumar) #399841ced732078] - doc: fix CJS-ESM selector in Safari (Bradley Farias) #401357fdb12739d] - doc: add timeout.close (Nikita Galkin) #4003681cb14bb58] - doc: clarify that ObjectWrap requires manual cleanup on shutdown (Gerhard Stöbich) #400748aad81dd99] - doc: add full list of subsystems (FrankQiu) #399719655329772] - doc: add Ayase-252 to collaborators (Qingyu Deng) #400786d399e11e9] - doc: fix CCM cipher example in MJS (Tobias Nießen) #39949d426ee9b17] - doc: fix property name 'detail' of performanceEntry (Christian Boehlke) #40019846e7e880e] - doc: fix list indentation in corepack.md (Alexey Ten) #40029b6dd2ea930] - doc: fix missing history version infs.md(Antoine du Hamel) #39972f666f5a8d1] - events: fix duplicate require which cause performance penalty (wwwzbwcom) #3989259fff925be] - (SEMVER-MINOR) fs: makeopenandclosestream override optional when unused (Antoine du Hamel) #40013a63a4bce90] - (SEMVER-MINOR) http: limit requests per connection (Artur K) #40082bc9c2ca6af] - http: remove CRLF variable (shfshanyue) #40101dd50b91f77] - lib: remove useless statement (Maledong) #39983608528028c] - lib: avoid creating a throw away object invalidateObject(Antoine du Hamel) #39807edcfffeaea] - lib: use standard property names (null) #39981640353af86] - lib,repl: ignore non-canBeRequiredByUsers built-in (Khaidi Chu) #399424444b5c938] - meta: update AUTHORS (Node.js GitHub Bot) #401484993318862] - meta: update GeoffreyBooth email addresses in AUTHORS and .mailmap (Rich Trott) #4013298d42fa1f4] - meta: add mailmap entry for LPardue (Rich Trott) #40129effdfa91be] - meta: update GeoffreyBooth email address (Geoffrey Booth) #40102588257c00a] - meta: add .mailmap entry for arcanis (Rich Trott) #401037ee3fbd1e0] - meta: update AUTHORS (Node.js GitHub Bot) #400872a41530a5e] - meta: consolidate AUTHORS entry for mikemaccana (Rich Trott) #40051a71579b05e] - meta: add more mailmap entries for bajtos (Rich Trott) #4002329104f5e64] - meta: consolidate AUTHORS entries for mithunsasidharan (Rich Trott) #40003381293f54a] - meta: update AUTHORS (Node.js GitHub Bot) #399571eca9bc5b2] - module: support pattern trailers for imports field (Guy Bedford) #400417376edca6d] - module: deprecate trailing slash pattern mappings (Guy Bedford) #4003992f182b23d] - module: fix $ pattern replacements (Guy Bedford) #40044d6124d8259] - repl: fix top level await with surrogate characters (Mestery) #399319a672961fa] - (SEMVER-MINOR) src: add --no-global-search-paths cli option (Cheng Zhao) #3975451f9ad4897] - (SEMVER-MINOR) src: add option to disable global search paths (Cheng Zhao) #3975495528b284d] - src: remove unnecessary comment and add a CHECK in crypto_tls.cc (Darshan Sen) #3999131994fbf8e] - src: register zlib external references for snapshot (Joyee Cheung) #40050cfcd57182b] - src: fix -Wunreachable-code-return error (Shelley Vohr) #400349f3a015b60] - src: add option to disable loading native addons (Dominic Elm) #39977570bef1710] - Revert "src: skip test_fatal/test_threads for Debug builds" (Anna Henningsen) #39954842f936e04] - src: use Isolate::TryGetCurrent where appropriate (Anna Henningsen) #39954fe920b6cbf] - (SEMVER-MINOR) src: make napi_create_reference accept symbol (JckXia) #3992673aa4e34ff] - src: fix C4805 MSVC warning (Michaël Zasso) #39998826eee363c] - src: register external references of PipeWrap for snapshot (Joyee Cheung) #399617a17cbfdea] - src: register external references of TTYWrap for snapshot (Joyee Cheung) #3996100cca48081] - src: register external references of TCPWrap for snapshot (Joyee Cheung) #399616095fb07b6] - src: register external references of SignalWrap for snapshot (Joyee Cheung) #39961db75711c5c] - src: register missing process methods external references (Joyee Cheung) #39961b4e074c295] - src: register missing stream wrap external references (Joyee Cheung) #39961a2c1c3ef64] - src: register external references of BaseObject for snapshot (Joyee Cheung) #399616fdf02523e] - src: register external references of node-report for snapshot (Joyee Cheung) #39961bef78a2f88] - src: register external references of dtrace for snapshot (Joyee Cheung) #3996197f3072ceb] - (SEMVER-MINOR) stream: add signal support to pipeline generators (Robert Nagy) #390676be405bd7b] - test: fix test-dgram-udp6-link-local-address on Windows (Michaël Zasso) #40005ec94bec9a3] - test: do not runtest-corepack-yarn-installwith no internet (Antoine du Hamel) #400904aa2610252] - test: update OpenSSL3 error messages for 3.0.0+quic (Daniel Bevenius) #400934367a61a9b] - test: mark test-crypto-timing-safe-equal-benchmarks flaky (Richard Lau) #400655b5e27281c] - test: fix internet/test-dns (Rich Trott) #4008367bbfeb7e1] - test: make tests pass on Windows with Unix EOL (Michaël Zasso) #40002a8c99d9f09] - tools: update doc generator dependencies (Michaël Zasso) #40042ec6de1195a] - tools: update ansi-regex in lint-md rollup (Rich Trott) #40112d55804ca4e] - tools: update all dependencies of markdown linter (Michaël Zasso) #40035f03bae7c82] - tools: update remark-html to v13.0.2 (Michaël Zasso) #4004399af21292f] - tools,build: update YAML files in preparation for linting (Rich Trott) #40007590ace418d] - tools,doc: fix misrendering of consecutive JS blocks (Rich Trott) #401465983568204] - worker: avoid potential deadlock on NearHeapLimit (Santiago Gimeno) #38403