lib: avoid creating a throw away object in validateObject

PR-URL: #39807 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
nodejs · Sep 21, 2021 · 6085280 · 6085280
1 parent 9a67296
commit 6085280
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/lib/internal/validators.js b/lib/internal/validators.js
@@ -140,12 +140,21 @@ function validateBoolean(value, name) {
     throw new ERR_INVALID_ARG_TYPE(name, 'boolean', value);
 }
 
+/**
+ * @param {unknown} value
+ * @param {string} name
+ * @param {{
+ *   allowArray?: boolean,
+ *   allowFunction?: boolean,
+ *   nullable?: boolean
+ * }} [options]
+ */
 const validateObject = hideStackFrames(
-  (value, name, {
-    nullable = false,
-    allowArray = false,
-    allowFunction = false,
-  } = {}) => {
+  (value, name, options) => {
+    const useDefaultOptions = options == null;
+    const allowArray = useDefaultOptions ? false : options.allowArray;
+    const allowFunction = useDefaultOptions ? false : options.allowFunction;
+    const nullable = useDefaultOptions ? false : options.nullable;
     if ((!nullable && value === null) ||
         (!allowArray && ArrayIsArray(value)) ||
         (typeof value !== 'object' && (