Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify that ObjectWrap requires manual cleanup on shutdown #40074

Closed
wants to merge 2 commits into from

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Sep 10, 2021

Clarify that ObjectWrap instances are not destroyed on process or worker shutdown and require manual destruction to avoid resource leaks.

fixes: #38816

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Sep 10, 2021
@Flarna Flarna changed the title doc: ObjectWrap requires manual cleanup on shutdown doc: clarify that ObjectWrap requires manual cleanup on shutdown Sep 10, 2021
Clarify that ObjectWrap instances are not destroyed on process or
worker shutdown and require manual destruction to avoid resource
leaks.
doc/api/addons.md Outdated Show resolved Hide resolved
@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 11, 2021
@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021
@github-actions
Copy link
Contributor

Landed in 8468bdb...7b4e6d4

@github-actions github-actions bot closed this Sep 15, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 15, 2021
Clarify that ObjectWrap instances are not destroyed on process or
worker shutdown and require manual destruction to avoid resource
leaks.

PR-URL: #40074
Fixes: #38816
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Flarna Flarna deleted the doc-objectwrap branch September 15, 2021 15:08
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
Clarify that ObjectWrap instances are not destroyed on process or
worker shutdown and require manual destruction to avoid resource
leaks.

PR-URL: #40074
Fixes: #38816
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
Clarify that ObjectWrap instances are not destroyed on process or
worker shutdown and require manual destruction to avoid resource
leaks.

PR-URL: #40074
Fixes: #38816
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memleak using worker and objects wrapping c++ instances
6 participants