Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update OpenSSL3 error messages for 3.0.0+quic #40093

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 13, 2021

This commit updates two OpenSSL 3.0.0 error messages required for
OpenSSL 3.0.0+quic.

Refs: nodejs/build#2759

This commit updates two OpenSSL 3.0.0 error messages required for
OpenSSL 3.0.0+quic.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 13, 2021
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2021
@nodejs-github-bot
Copy link
Collaborator

@richardlau
Copy link
Member

Re. CI -- openssl300 is expected to fail as it is still on OpenSSL 3.0.0-alpha16. I will need to update the CI simultaneously with landing this PR.

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 13, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@richardlau richardlau self-assigned this Sep 13, 2021
@richardlau
Copy link
Member

CI is passing except for the expected failure on openssl300. I'll simultaneously update the CI and land this when this PR is ready to land (either fast tracked or after the wait period).

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 13, 2021

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2021
@github-actions
Copy link
Contributor

Landed in 5c1adda...e016cc7

@github-actions github-actions bot closed this Sep 13, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 13, 2021
This commit updates two OpenSSL 3.0.0 error messages required for
OpenSSL 3.0.0+quic.

PR-URL: #40093
Refs: nodejs/build#2759
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
This commit updates two OpenSSL 3.0.0 error messages required for
OpenSSL 3.0.0+quic.

PR-URL: #40093
Refs: nodejs/build#2759
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
This commit updates two OpenSSL 3.0.0 error messages required for
OpenSSL 3.0.0+quic.

PR-URL: #40093
Refs: nodejs/build#2759
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants