Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add Ayase-252 to collaborators #40078

Closed
wants to merge 1 commit into from
Closed

doc: add Ayase-252 to collaborators #40078

wants to merge 1 commit into from

Conversation

Ayase-252
Copy link
Member

Fixes: #39912

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 11, 2021
@Ayase-252
Copy link
Member Author

Please 👍 for fast-tracking.

@gireeshpunathil gireeshpunathil added meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs. labels Sep 11, 2021
@aduh95
Copy link
Contributor

aduh95 commented Sep 11, 2021

Welcome onboard :)

@Ayase-252 Ayase-252 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40078
✔  Done loading data for nodejs/node/pull/40078
----------------------------------- PR info ------------------------------------
Title      doc: add Ayase-252 to collaborators (#40078)
Author     Qingyu Deng  (@Ayase-252)
Branch     Ayase-252:onboarding -> nodejs:master
Labels     doc, meta, notable-change
Commits    1
 - doc: add Ayase-252 to collaborators
Committers 1
 - Qingyu Deng 
PR-URL: https://github.com/nodejs/node/pull/40078
Fixes: https://github.com/nodejs/node/issues/39912
Reviewed-By: Gireesh Punathil 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40078
Fixes: https://github.com/nodejs/node/issues/39912
Reviewed-By: Gireesh Punathil 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 11 Sep 2021 05:38:24 GMT
   ✔  Approvals: 2
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/40078#pullrequestreview-751892302
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40078#pullrequestreview-751901325
   ✖  This PR needs to wait 44 more hours to land
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1224020467

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 11, 2021
@gireeshpunathil
Copy link
Member

@Ayase-252 - looks like we need to add fast-track label, to get the effect. can you try once again, with adding the label?

@Ayase-252 Ayase-252 added fast-track PRs that do not need to wait for 48 hours to land. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 11, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Ayase-252. Please 👍 to approve.

@Ayase-252
Copy link
Member Author

Should I add commit-queue now?

@gireeshpunathil
Copy link
Member

@aduh95 - looks like we need to approve the fast-track in the new comment that the bot has added (I wasn't aware of this process change)

@gireeshpunathil
Copy link
Member

Should I add commit-queue now?

let us wait till we get 2 fast-track approvals.

@gireeshpunathil
Copy link
Member

@Ayase-252 - go ahead now!

@Ayase-252 Ayase-252 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2021
@aduh95
Copy link
Contributor

aduh95 commented Sep 11, 2021

Fast track request approved, this can land (either using git node land or using the commit queue).

@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2021
@github-actions
Copy link
Contributor

Landed in f8836b2...3e8eda2

@github-actions github-actions bot closed this Sep 11, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 11, 2021
@Ayase-252 @nodejs-github-bot
doc: add Ayase-252 to collaborators
3e8eda2 
Fixes: #39912

PR-URL: #40078
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@Ayase-252 Ayase-252 deleted the onboarding branch September 13, 2021 09:15
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Ayase-252 @BethGriggs
doc: add Ayase-252 to collaborators
ea2c387 
Fixes: #39912

PR-URL: #40078
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
BethGriggs added a commit that referenced this pull request Sep 21, 2021
@BethGriggs
2021-09-22, Version 16.10.0 (Current)
45a042b 
Notable changes:

crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067

PR-URL: TODO
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@Ayase-252 @BethGriggs
doc: add Ayase-252 to collaborators
9655329 
Fixes: #39912

PR-URL: #40078
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
BethGriggs added a commit that referenced this pull request Sep 21, 2021
@BethGriggs
2021-09-22, Version 16.10.0 (Current)
10b4fe1 
Notable changes:

crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067

PR-URL: TODO
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
BethGriggs added a commit that referenced this pull request Sep 22, 2021
@BethGriggs
2021-09-22, Version 16.10.0 (Current)
aff2a0a 
Notable changes:

crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067

PR-URL: #40175
BethGriggs added a commit that referenced this pull request Sep 22, 2021
@BethGriggs
2021-09-22, Version 16.10.0 (Current)
8d5675e 
Notable changes:

crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067

PR-URL: #40175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nominating Qingyu Deng (Ayase-252) as a collaborator
4 participants
@Ayase-252 @aduh95 @gireeshpunathil @nodejs-github-bot