Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix C4805 MSVC warning #39998

Closed
wants to merge 1 commit into from
Closed

src: fix C4805 MSVC warning #39998

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 5, 2021

'==' : unsafe mix of type 'bool' and type 'int' in operation

@targos
src: fix C4805 MSVC warning
6969c35 
'==' : unsafe mix of type 'bool' and type 'int' in operation
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 5, 2021
@targos targos added windows Issues and PRs related to the Windows platform. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 5, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39791/

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2021

Fast-track has been requested by @jasnell. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39798/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39823/

targos added a commit that referenced this pull request Sep 7, 2021
@targos
src: fix C4805 MSVC warning
dadea4a 
'==' : unsafe mix of type 'bool' and type 'int' in operation

PR-URL: #39998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@targos
Copy link
Member Author

targos commented Sep 7, 2021

Landed in dadea4a

@targos targos closed this Sep 7, 2021
@targos targos deleted the fix-bool-warning branch September 7, 2021 10:23
@targos targos removed fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 7, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@targos @BethGriggs
src: fix C4805 MSVC warning
73aa4e3 
'==' : unsafe mix of type 'bool' and type 'int' in operation

PR-URL: #39998
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @jasnell @cjihrig @tniessen