Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: update AUTHORS #40148

Merged
merged 1 commit into from
Sep 21, 2021
Merged

meta: update AUTHORS #40148

merged 1 commit into from
Sep 21, 2021

Conversation

nodejs-github-bot
Copy link
Collaborator

If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.js and submits a new PR or updates an existing PR.

Please note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 19, 2021
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2021
@github-actions github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 21, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40148
✔  Done loading data for nodejs/node/pull/40148
----------------------------------- PR info ------------------------------------
Title      meta: update AUTHORS (#40148)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/authors-update -> nodejs:master
Labels     meta
Commits    1
 - meta: update AUTHORS
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/40148
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40148
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 19 Sep 2021 00:13:30 GMT
   ✔  Approvals: 4
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758160452
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758162439
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758693926
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40148#pullrequestreview-758984059
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1257650399

PR-URL: #40148
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@Trott Trott merged commit d05cca9 into master Sep 21, 2021
@Trott
Copy link
Member

Trott commented Sep 21, 2021

Landed in d05cca9

@Trott Trott deleted the actions/authors-update branch September 21, 2021 12:56
@nodejs nodejs deleted a comment Sep 21, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40148
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40148
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants