Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] start serverside-apply documentation #12898

Conversation

kwiesmueller
Copy link
Member

Add documentation for the serverside-apply alpha feature

/milestone 1.14

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2019
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 28, 2019

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit b7f174b

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5c77ef3685378d0008ade902

@k8s-ci-robot k8s-ci-robot requested review from aanm and ahmetb February 28, 2019 12:54
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language labels Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: stewart-yu

If they are not already assigned, you can assign the PR to them by writing /assign @stewart-yu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2019
@kwiesmueller
Copy link
Member Author

/milestone v1.14

@kwiesmueller
Copy link
Member Author

/cc @apelisse @jennybuckley @lavalamp

@kbhawkey
Copy link
Contributor

kbhawkey commented Feb 28, 2019

@kwiesmueller, you intend to add one commit, right?

@kwiesmueller
Copy link
Member Author

Yeah, I added one to at least have the PR open.
I guess when switching to the dev-1.14 branch i failed to rebase first. Let me check.

Himanshu Pandey and others added 13 commits February 28, 2019 15:23
* Updated Recommended docker version

* minor changes
* First pass on a blog post about CVE-2019-5736.

* Clarify that k8s is not the problem.

* Fix example of pinning to an image hash.

My mistake deftly caught by @zparnold.

Co-Authored-By: coderanger <[email protected]>

* Add links to the rest of the notices or releases.

* Add ways to get more info.

* RHEL link for those that don't selinux.

* Link to Rancher's back ports.
"Kubernetes control panel" instead of "Kubernetes control plane"
kubernetes#12404)

* Adding proposed blog post for building-a-kubernetes-edge-control-plane-for-envoy-v2

* Update article with improvements and author list

* Update and rename building-a-kubernetes-edge-control-plane-for-envoy-v2.md to 2019-02-11-building-a-kubernetes-edge-control-plane-for-envoy-v2.md

* Add extra coverage about use of Golang in Ambassador 0.50

* Minor typo fixes

* Minor typo fix, and merge fix with date

* Update 2019-02-11-building-a-kubernetes-edge-control-plane-for-envoy-v2.md

* Delete building-a-kubernetes-edge-control-plane-for-envoy-v2.md

* Update 2019-02-11-building-a-kubernetes-edge-control-plane-for-envoy-v2.md
* Fix a misleading word in containers/images.md

* Rev Fix a misleading word in containers/images.md
* Add option to install kubectl via scoop

* Review suggestions

* Fixed tab rendering

* Fixed list numbering
jygastaud and others added 20 commits February 28, 2019 15:23
* Fix Ingress callouts, links, nav, and templating

* Update ingress.md

* Update ingress-minikube.md

* Delete .md that caused 404

* Delete .md that caused 404

* Update ingress-controllers.md

* Update ingress-minikube.md

* spell check pass

* Update ingress.md

* Update ingress-minikube.md
* Fix sticky footer issue

* Fix merge conflict

* Aesthetic changes to 404 page
* Move docker credentials import to task documentation

Relevant to kubernetes#12072

* Call out helpful note about per-namespace secrets
Tidy up protocol support to show that TCP and UDP have support in
stable, whereas SCTP support is in alpha. For HTTP, direct users to
read up on Ingress instead.
- Adjusts levels
- Removes some obsolete info
- Rewrite of some of the intro material
* docs: update acs-engine -> aks-engine

acs-engine has been deprecated by Microsoft in favor of aks-engine

* chore: PR feedback

* fix missing AKS
…Using a Service” (kubernetes#12706)

* Reference terms in glossary

* Enable syntax highlighting for shell snippets
… $ and also remove text which is not appropiate for end user (kubernetes#12793)
* Fix SSH tunnel links

* Removed reference to GKE, which seemed to prompt the initial removal.
* Fixed the link to refer back to the correct paragraph now that it exists again.
* Noted deprecation of SSH tunnels but work to create a replacement.

Fix kubernetes#8262

This reverts commit 1da6560.

This reverts commit b8b71b6.

* Update master-node-communication.md
@kwiesmueller kwiesmueller force-pushed the serverside-apply-documentation branch from 5b85425 to b7f174b Compare February 28, 2019 14:23
@kwiesmueller
Copy link
Member Author

Okay that made it even worse.
Sorry, it's my first PR to the website repo and I wasn't which branch to select.
Is dev-1.14 correct for this?

@kbhawkey
Copy link
Contributor

Okay that made it even worse.
Sorry, it's my first PR to the website repo and I wasn't which branch to select.
Is dev-1.14 correct for this?

Yes, dev-1.14 is the correct branch, cc @jimangel

@jimangel
Copy link
Member

@kwiesmueller it looks like you might have combined some docs from other branches. I would recommend fixing them and force pushing back to this branch. Alternately, you can close this PR and open a new one with your changes if it's easier.

Either way, there is a "ready for review" deadline tomorrow (Monday) and it would be great to not have this at risk due to merge conflicts :)

Thanks!

@jimangel jimangel added this to the 1.14 milestone Mar 10, 2019
@kwiesmueller
Copy link
Member Author

closed in favor of #13077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.