Fix SSH tunnel links #12585
Merged
Fix SSH tunnel links #12585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed reference to GKE, which seemed to prompt the initial removal. * Fixed the link to refer back to the correct paragraph now that it exists again. * Noted deprecation of SSH tunnels but work to create a replacement. Fix kubernetes#8262 This reverts commit 1da6560. This reverts commit b8b71b6.
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 03d13bf https://deploy-preview-12585--kubernetes-io-master-staging.netlify.com |
|
/assign @steveperry-53 |
|
@steveperry-53 please review the updates made |
zparnold
reviewed
Feb 13, 2019
| This tunnel ensures that the traffic is not exposed outside of the network in | ||
| which the nodes are running. | ||
|
|
||
| SSH tunnels are deprecated, but a replacement is being designed. |
There was a problem hiding this comment.
Suggested change
| SSH tunnels are deprecated, but a replacement is being designed. | |
| SSH tunnels are currently deprecated so you shouldn't opt to use them unless you know what you are doing. A replacement for this communication channel is being designed. |
There was a problem hiding this comment.
Oh that's great - much clearer - thank you! (And sorry for missing it before!)
|
@justinsb I made a suggestion based on something that may sound differently to a user. Can you please let me know if it's still factual? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kwiesmueller
pushed a commit
to kwiesmueller/website
that referenced
this pull request
Feb 28, 2019
* Fix SSH tunnel links * Removed reference to GKE, which seemed to prompt the initial removal. * Fixed the link to refer back to the correct paragraph now that it exists again. * Noted deprecation of SSH tunnels but work to create a replacement. Fix kubernetes#8262 This reverts commit 1da6560. This reverts commit b8b71b6. * Update master-node-communication.md
krmayankk
pushed a commit
to krmayankk/kubernetes.github.io
that referenced
this pull request
Mar 11, 2019
* Fix SSH tunnel links * Removed reference to GKE, which seemed to prompt the initial removal. * Fixed the link to refer back to the correct paragraph now that it exists again. * Noted deprecation of SSH tunnels but work to create a replacement. Fix kubernetes#8262 This reverts commit 1da6560. This reverts commit b8b71b6. * Update master-node-communication.md
yagonobre
pushed a commit
to yagonobre/website
that referenced
this pull request
Mar 14, 2019
* Fix SSH tunnel links * Removed reference to GKE, which seemed to prompt the initial removal. * Fixed the link to refer back to the correct paragraph now that it exists again. * Noted deprecation of SSH tunnels but work to create a replacement. Fix kubernetes#8262 This reverts commit 1da6560. This reverts commit b8b71b6. * Update master-node-communication.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8262
This reverts commit 1da6560.
This reverts commit b8b71b6.