Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply content_template and follow the style guide #12759

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Apply content_template and follow the style guide #12759

merged 1 commit into from
Feb 28, 2019

Conversation

makocchi-git
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2019
@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 85823f5

https://deploy-preview-12759--kubernetes-io-master-staging.netlify.com

@makocchi-git
Copy link
Contributor Author

preview is here
original

@makocchi-git
Copy link
Contributor Author

/assign @zhangxiaoyu-zidif

@DanyC97
Copy link
Contributor

DanyC97 commented Feb 26, 2019

cheers @makocchi-git , lgtm (although i know my review doesn't count at this stage )

@makocchi-git
Copy link
Contributor Author

makocchi-git commented Feb 28, 2019 •
edited
Loading

ping @zhangxiaoyu-zidif

@zparnold
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 235f6f6 into kubernetes:master Feb 28, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
@makocchi-git
apply content_template and follow the style guide (kubernetes#12759)
c9d67b0
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
@makocchi-git
apply content_template and follow the style guide (kubernetes#12759)
385e49f
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@makocchi-git @yagonobre
apply content_template and follow the style guide (kubernetes#12759)
ea7f4ea
@makocchi-git makocchi-git deleted the fix/run_mz branch June 18, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j3ffml j3ffml Awaiting requested review from j3ffml

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@zhangxiaoyu-zidif zhangxiaoyu-zidif

@zparnold zparnold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@makocchi-git @DanyC97 @zparnold @k8s-ci-robot @zhangxiaoyu-zidif