Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Recommended docker version #12591

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Updated Recommended docker version #12591

merged 2 commits into from
Feb 12, 2019

Conversation

hpandeycodeit
Copy link

Issue #1402

  • Updated Docker recommended version to 18.06.2
  • Added a note about CVE-2019-5736

https://access.redhat.com/security/cve/cve-2019-5736

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Feb 11, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 11, 2019
@netlify
Copy link

netlify bot commented Feb 11, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 11e65cb

https://deploy-preview-12591--kubernetes-io-master-staging.netlify.com

neolit123
neolit123 approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @hpandeycodeit
added a couple of minor comments, but looks good.

/priority critical-urgent
/area security
/kind bug
@kubernetes/sig-cluster-lifecycle-pr-reviews

content/en/docs/setup/cri.md
@@ -45,7 +45,7 @@ Use the following commands to install Docker on your system:
stable"

## Install docker ce.
apt-get update && apt-get install docker-ce=18.06.0~ce~3-0~ubuntu
apt-get update && apt-get install docker-ce=18.06.2~ce~3-0~ubuntu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/website/pull/12591/files#diff-9b5d940e9fc0e3fab81c81aad0dc300fR23
please change this value to 18.06.2 too.

Version 18.06.2 is recommended, ....

content/en/docs/setup/cri.md Outdated
@@ -109,6 +109,14 @@ systemctl restart docker
Refer to the [official Docker installation guides](https://docs.docker.com/engine/installation/)
for more information.

Please Note:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the text Please Note: and wrap the whole block with {{< caution >}} .... {{< /caution >}}

example here:
https://github.com/kubernetes/website/blob/807ded0b0df21c37239e895943a8b77c6efdd0cc/content/en/docs/setup/independent/high-availability.md

also please move this block above the Docker section.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 Thanks for pointing it out.Corrected it. :)

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/bug Categorizes issue or PR as related to a bug. labels Feb 12, 2019
@neolit123
Copy link
Member

neolit123 commented Feb 12, 2019 •
edited
Loading

thanks @hpandeycodeit !!

preview: https://deploy-preview-12591--kubernetes-io-master-staging.netlify.com/docs/setup/cri/

/lgtm
/assign @jimangel @tengqm
@kubernetes/sig-cluster-lifecycle-pr-reviews

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2019
yagonobre
yagonobre reviewed Feb 12, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hpandeycodeit
/lgtm

@jimangel
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@neolit123 neolit123 mentioned this pull request Feb 12, 2019
Closed
@k8s-ci-robot k8s-ci-robot merged commit be4bee1 into kubernetes:master Feb 12, 2019
@hpandeycodeit
Copy link
Author

Thank you! :)

kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
Updated Recommended docker version (kubernetes#12591)
2331f93 
* Updated Recommended docker version

* minor changes
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
Updated Recommended docker version (kubernetes#12591)
a313d27 
* Updated Recommended docker version

* minor changes
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@yagonobre
Updated Recommended docker version (kubernetes#12591)
2ed7fa4 
* Updated Recommended docker version

* minor changes
@hpandeycodeit hpandeycodeit mentioned this pull request May 9, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yagonobre yagonobre yagonobre left review comments

@neolit123 neolit123 neolit123 approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@neolit123 neolit123

@jimangel jimangel

@tengqm tengqm

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hpandeycodeit @neolit123 @jimangel @k8s-ci-robot @yagonobre @tengqm