Server-side Apply

[apelisse]

Feature Description

• One-line feature description (can be used as a release note): Move "apply" and declarative object management from kubectl to the apiserver in order to fix many of the existing bugs that we can't fix today. Also use that opportunity to add "field ownership".
• Primary contact (assignee): @apelisse @lavalamp
• Responsible SIGs: sig-api-machinery sig-cli (wg-apply was created for that purpose).
• Design proposal link (community repo): https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/555-server-side-apply
• Link to e2e and/or unit tests:
  • Unit-tests:
    • https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/typed/merge_test.go
    • https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/typed/deduced_test.go
    • https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/typed/symdiff_test.go
    • https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/typed/toset_test.go
    • https://github.com/kubernetes-sigs/structured-merge-diff/blob/master/typed/validate_test.go
    • https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/fieldmanager_test.go
  • Integration tests:
    • https://github.com/kubernetes/kubernetes/blob/master/test/cmd/apply.sh
    • https://github.com/kubernetes/kubernetes/blob/master/test/integration/apiserver/apply/apply_test.go
    • https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/test/integration/apply_test.go
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @lavalamp @pwittrock @erictune
• Approver (likely from SIG/area to which feature belongs): @bgrant0607
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y) 1.14
  • Beta release target (x.y) 1.15
  • Stable release target (x.y) 1.21

[idvoretskyi]

/assign @apelisse

[zparnold]

Looks like we still need some docs to get this feature ready for release @apelisse
Could I please get some help with that? If there’s anything I can do to assist please let me know

At a minimum we're looking to have a placeholder PR on the kubernetes/website repo. The process is fairly straightforward: checkout release-1.11 branch, make a placeholder commit, push it to your fork, and raise a PR between it and the release-1.11 branch, with /hold status.

THANKS SO MUCH!!!!!

[justaugustus]

@apelisse I noticed the milestone change. Are you planning on pulling this from the 1.11 release?

[apelisse]

Yeah, not in 1.11. I'm updating the body.

[justaugustus]

Thanks @apelisse!

[kwiesmueller]

Unsure if it is the right place to comment about this, but we have been working on our own kind of "server side apply" by building https://github.com/seibert-media/dimios
While this is solely a slack time project which we hope to build our future interaction with Kubernetes on, we both stumbled into problems with the entire apply process (discussed on slack with some people) but also did some thinking on how to best approach this.

While I haven't worked on K8s directly myself yet, I could imagine to contribute to this idea/feature if possible/wanted.

[apelisse]

Can you send this as an email to [email protected]? We can follow-up there.

[kwiesmueller]

@apelisse I am not allowed to post messages to said group ([email protected])

[apelisse]

Sorry, you may need to join the group first: https://groups.google.com/forum/#!forum/kubernetes-wg-apply

Blue button, "Join group to post" (top left)

[justaugustus]

@apelisse @kubernetes/sig-api-machinery-feature-requests @kubernetes/sig-cli-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

• One-line feature description (can be used as a release note):
• Primary contact (assignee):
• Responsible SIGs:
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
• Approver (likely from SIG/area to which feature belongs):
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y)

Set the following:

• Description
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

[apelisse]

I think everything is there @justaugustus! Thank you

[justaugustus]

Thanks for the update, @apelisse!

[zparnold]

Hey there! @apelisse I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[apelisse]

@zparnold Changed the milestone from 1.12 to 1.13 :-). You can forget about this for now, thanks.

[lavalamp]

It'll be alpha, it would be good to document. Jenny said she'd try and put something together. [EDIT: wrong issue, ignore]

…

On Tue, Aug 21, 2018 at 12:44 PM Antoine Pelisse ***@***.***> wrote: @zparnold <https://github.com/zparnold> Changed the milestone from 1.12 to 1.13 :-). You can forget about this for now, thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#555 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAnglgxXgV0DuPpOq4P4UZZjMY8Fcx6Lks5uTGMDgaJpZM4TKb_j> .

[annajung]

After speaking with @apelisse, this enhancement has been deferred and will no longer be tracked for 1.21

[apelisse]

We've updated the tracking sheet, can we mark this as a 1.22 milestone? Also, this is code complete already.

[JamesLaverack]

@apelisse Of course. Thanks for updating the tracking sheet!

/milestone v1.22

[salaxander]

@apelisse - 1.22 enhancements team here! Looks like we're on track for 1.22. I think the only thing would maybe be updating the graduation criteria of the KEP to reference 1.22 rather than 1.21 for GA. Also, if you're able to update the structure of the KEP for the latest template (https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template), that would be awesome. Though, I don't think any of that would be a problem for enhancements freeze on 5/13.

Let us know If there's anything we can do to help!

CC @JamesLaverack

[apelisse]

Not super excited to spend some time updating the KEP template now that we're all done with the feature ;-)

[salaxander]

Tracking #2732 for the updates. Thanks!

[PI-Victor]

Hello @apelisse 👋, 1.22 Docs release lead here.
This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

p.s.: please don't forget to update the ServerSideApply feature gate in the feature gates table to reflect the graduation.

[apelisse]

Thanks, we've already updated most of the documentation in master branch, earlier this cycle. We should be good to go!

p.s.: please don't forget to update the ServerSideApply feature gate in the feature gates table to reflect the graduation.

Done here: kubernetes/website#28038

[salaxander]

Hi @apelisse! Checking in from the enhancements team as we're just over 2 weeks away from code freeze. Are there any open or merged k/k PRs we should be tracking for this? Thanks!

[kwiesmueller]

Hi @salaxander! To my knowledge there is nothing waiting for the code freeze.
We have some work happening in controller-runtime but that's not affected.
So we should be good for v1.22.

[salaxander]

Hey @apelisse and @kwiesmueller - Can you open a PR on the KEP to change to status to implemented? At that point we can close out the issue :)

Thanks!

[JamesLaverack]

@salaxander @apelisse Can we close this issue? We're all done here right after 1.22? :D

[apelisse]

Yep, sounds good!

[apelisse]

3.5 years later ;-)

[sbose78]

Could we update this in the description https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/0006-apply.md .. to something that works, please :-) ?

[apelisse]

Could we update this in the description https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/0006-apply.md .. to something that works, please :-) ?

Done! Thanks for noticing ;-)

[mimowo]

Not sure this is the good place to xreference as the issue is already closed, but potential users of SSA are likely to look here. Cross referencing an open issue for better visibility: kubernetes/kubernetes#113482.

EDIT: opened the PR to update the KEP as well for better visibility: #4308.