Kubectl Diff

[seans3]

Feature Description

• One-line feature description (can be used as a release note): Users can run a
  kubectl command to view the difference between a locally declared object
  configuration and the current state of a live object.
• Primary contact (assignee): @apelisse
• Responsible SIGs: @kubernetes/sig-cli
• Design proposal link (community repo): https://goo.gl/UVsM6A
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/20200115-kubectl-diff.md
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from
  code-area OWNERS file) agreed to review. Reviewers from multiple companies
  preferred: @pwittrock, @mengqiy
• Approver (likely from SIG/area to which feature belongs): @pwittrock
• Feature target (which target equals to which milestone):
  • Alpha release target (1.8)
  • Beta release target (1.13)
  • Stable release target (1.18)

[seans3]

/kind feature

[seans3]

/sig cli

[zacharysarah]

@seans3 👋 Please open a documentation PR and add a link to the 1.9 tracking spreadsheet. Thanks in advance!

[zacharysarah]

@seans3 Bump for docs ☝️

/cc @idvoretskyi

[idvoretskyi]

@seans3 @apelisse @kubernetes/sig-cli-feature-requests any updates on the docs status?

A friendly reminder on docs deadline tomorrow.

/cc @zacharysarah

[apelisse]

I've removed the needs-doc. Alpha features doesn't have to be documented on day one. Thanks

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[nottrobin]

Where's the code for this feature? I understand there's not yet proper documentation, but I was hoping I might be able to read the code so understand what might be causing kubernetes/kubernetes#61145, which is an issue for me too.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[nottrobin]

/remove-lifecycle rotten

[justaugustus]

@apelisse
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

• Description
• Milestone
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

cc @idvoretskyi

[pwittrock]

@apelisse Think we could move this out of alpha for 1.11?

[apelisse]

@justaugustus We'll try to get everything ready for a nice alpha release in 1.11. Labels are up-to-date, I updated the milestone, thanks!

[justaugustus]

Thanks for getting the labels updated, @apelisse!
Would you mind also updating the feature targets within the description?

[palnabarun]

/reopen

[k8s-ci-robot]

@palnabarun: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palnabarun]

Sorry, I accidentally closed the issue.

[palnabarun]

As an added note, I am updating the issue description with KEP PR.

[apelisse]

Thanks!

…

On Tue, Jan 21, 2020 at 12:24 PM Nabarun Pal ***@***.***> wrote: As an added note, I am updating the issue description with KEP PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#491?email_source=notifications&email_token=AAOXDLAXVM7WQY4K34RMKS3Q65KX3A5CNFSM4EAONOV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJREDFQ#issuecomment-576864662>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOXDLDKMOODFA6EESTV5HLQ65KX3ANCNFSM4EAONOVQ> .

[palnabarun]

@apelisse Just a friendly reminder, we are just 2 days away from the Enhancement Freeze (3 PM Pacific Time, Tuesday, January 28th).

[palnabarun]

@apelisse I see that the last activity on the KEP PR was 10 days ago. Let us know if any help is required from the release team to get more traction on this.

[apelisse]

I'm on it today, thanks!

[palnabarun]

Awesome!

[palnabarun]

Updated the KEP link in the description.

[palnabarun]

@apelisse A small nit, the KEP status is set to Implemented whereas it should have been Implementable. Implemented is set after the release cycle when the enhancement graduates to stable.

Can you please set it to Implementable?

[palnabarun]

Hi @apelisse, just a friendly reminder that the Code Freeze will go into effect on Thursday 5th March.

Can you please link all the k/k PRs or any other PRs which should be tracked for this enhancement?

Thank You :)

[apelisse]

We don't have any changes to do for this. We're working on improving the documentation at this point:

kubernetes/kubernetes#87805

[palnabarun]

Thank you @apelisse for the updates. :)

[sethmccombs]

Hey @apelisse -

Seth here, Docs shadow on the 1.18 release team.

Does this enhancement work planned for 1.18 require any new docs or modifications to existing docs?

If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If doc updates are required, reminder that the placeholder PRs against k/website (branch dev-1.18) are due by Friday, Feb 28th.

Let me know if you have any questions!

[apelisse]

I think we've already updated the docs for this feature, but I'll make sure everything is up-to-date, thanks!

[VineethReddy02]

@apelisse If you have already updated the docs, Can you share the link to the PR here.
Thanks!

[apelisse]

@julianvmodesto Do you happen to remember?

[julianvmodesto]

@zhouya0 merged a couple of PRs for docs here:

kubernetes/website#18665
kubernetes/website#18481

Issue: kubernetes/kubernetes#86525

[palnabarun]

Hi @apelisse, since this enhancement graduated to Stable this release 🚀, the status can now be set to be Implemented.

Can you please update the status? After that, we will close this issue.

[apelisse]

#1627

[liskl]

@julianvmodesto does this support the -k argument if you remember

Like can it diff what a kubectl apply -k --dry-run outputs agianst what's in the cluster?

[apelisse]

I'm pretty sure it does. If it doesn't, then there must be a bug that should be fixed. I couldn't find a test that tests that so we should probably write one.