Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference glossary definitions in “Connect a Front End to a Back End Using a Service” #12706

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Feb 19, 2019

Add references from https://kubernetes.io/docs/tasks/access-application-cluster/connecting-frontend-backend/ to relevant glossary definitions

Whilst I'm at it: mark shell snippets as shell

Relevant to #12554

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Feb 19, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 19, 2019
@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0d844b0

https://deploy-preview-12706--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

@sftim Thanks for the PR. This still does not address #12554. There is another relevant #12639 that might help the developers with the link to the .yaml files.

@Rajakavitha1
Copy link
Contributor

Rajakavitha1 commented Feb 19, 2019

@sftim also providing a reference to glossary definitions for every occurrence of the term defies the purpose of a glossary list and makes the terms quite repetitious.

"In writing, especially professional documents, you will be using words that are unfamiliar with your reader. If an unfamiliar word in your text is used a minimal amount of times you can describe the meaning right next to the usage. When you use unfamiliar words throughout the entire text, you must place a definition in the glossary because it can get quite repetitious to continue to state the definition throughout the entire text. In professions, ie: the sciences, your readers may not understand the definition to fancy scientific terms. Using a glossary enables you to provide a definition that readers can easily locate if they need to."

@sftim
Copy link
Contributor Author

sftim commented Feb 19, 2019

The way I see it, this project has indeed placed the definition in a glossary. Hence, referring to it.

I'd like to understand more about the disadvantages of adding these tooltips / hyperlinks, so that I can make sure the changes I suggest are worthwhile.

@Rajakavitha1
Copy link
Contributor

Rajakavitha1 commented Feb 19, 2019

The way I see it, this project has indeed placed the definition in a glossary. Hence, referring to it.

I'd like to understand more about the disadvantages of adding these tooltips / hyperlinks, so that I can make sure the changes I suggest are worthwhile.

I am sure it is always nice to have a tooltip for the terms that have definitions. However, adding a tooltip to all occurrences of the term in the entire documentation ( to remain consistent) may be a very tedious task.

@Rajakavitha1
Copy link
Contributor

/assign @zparnold

@Rajakavitha1
Copy link
Contributor

@zparnold Please take a look at this PR.

@Rajakavitha1
Copy link
Contributor

The way I see it, this project has indeed placed the definition in a glossary. Hence, referring to it.

I'd like to understand more about the disadvantages of adding these tooltips / hyperlinks, so that I can make sure the changes I suggest are worthwhile.

Some of the disadvantages of using tooltips extensively:
a. The text will be readable with the flow which is not favorable in this context because the content of the hint interrupts the flow of the information and data displayed in the main content.
b. From accessibility point of view - Tooltips do not usually appear on mobile operating systems, because there is no cursor, unless you have a touch screen with a fancy digital pen which allows for hover to be triggered, you won’t be able to see the hint inside the tooltip.

@zparnold
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 04ddaa4 into kubernetes:master Feb 28, 2019
@sftim sftim deleted the task_connecting-frontend-backend_refer_to_glossary branch February 28, 2019 09:32
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
…Using a Service” (kubernetes#12706)

* Reference terms in glossary

* Enable syntax highlighting for shell snippets
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
…Using a Service” (kubernetes#12706)

* Reference terms in glossary

* Enable syntax highlighting for shell snippets
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
…Using a Service” (kubernetes#12706)

* Reference terms in glossary

* Enable syntax highlighting for shell snippets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants