Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the parallel-processing-expansion.md task file and remove $ #12794

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

DanyC97
Copy link
Contributor

@DanyC97 DanyC97 commented Feb 22, 2019

This PR brings https://kubernetes.io/docs/tasks/job/parallel-processing-expansion/ in line with the style guide

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language labels Feb 22, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 22, 2019

/assign @cody-clark

@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f9d3d80

https://deploy-preview-12794--kubernetes-io-master-staging.netlify.com

@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 22, 2019

This PR is one of the #12740 's tasks

@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 25, 2019

any help here with reviewing please ?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2019
@DanyC97 DanyC97 changed the title Update the parallel-processing-expansion.md task file to bring it inl… Update the parallel-processing-expansion.md task file and remove $ Feb 26, 2019
@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 26, 2019

reduced the scope as per @zacharysarah comment made on another PR

everything else will follow in a different PR

@DanyC97
Copy link
Contributor Author

DanyC97 commented Feb 28, 2019

/assign @zparnold
/unassign @cody-clark

@k8s-ci-robot k8s-ci-robot assigned zparnold and unassigned cody-clark Feb 28, 2019
@zparnold
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2f6bee1 into kubernetes:master Feb 28, 2019
@DanyC97 DanyC97 deleted the tasks-job-ppq branch February 28, 2019 11:04
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants