-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List inaccessible or 404 urls #17649
Comments
Just so you know, @tanjunchen, SIG Docs typically doesn't fix hyperlinks in older blog posts. Ideally the targets of links would stay valid; where that doesn't happen, it's OK to leave older blog posts as-is. I think the cut-off is 24 months but I haven't checked. |
@sftim OK.Thanks |
The missing numbers in the table (1-258) have been modified in the following pr.some url will not to be midified in olders bolg. |
Only 258? I got about 167 of local deadlinks and 609 globaly*. If #15893 is still planed somewhen, it will be important to have close to zero local deadlinks. External links are out the control, but the local ones not. I think it's important to fix the blog links too, but not as a life matter issue. There like 16 links in blogs that generate errors (while being referenced with a pre-hugo URL structure), and they can and should be fixed IMHO. But there are changed external links, mistyped localized docs, dead external links... like a lot. My approach is a bit simpler... start cleanup from more important documents (documentation) to less (old blog), smaller but consistent bytes - (like fix 1 issue - but for every localization (if found in localized documents)). P.S. |
@butuzov good job! Thanks I agree with you, but it is a bit of a hassle to introduce a detection tool (CI) because some links are not really links. So, we should start by modifying the work from important folders, such as documentation、readme.md. Then modify the links in some blogs (the most recent blog), and finally the link availability of the entire site will increase. I open this issue, the purpose is to let everyone modify it together, this will quickly modify the wrong link. Can you put the location of the link that cannot be accessed and the file where the link is located? Another problem is that localized links have to be modified due to changes in the original link. Is it clear that there is a better solution? |
@tanjunchen its to early to think on the introduction of CI tool. There are too many issues atm. BTW, can I give you advice? Do not pack all fixes to broken links in on PR. I was asked to made separate requests on my first one. There are number of reasons behind it:
I thought it would take a year or so occasionally fixing broken links for me alone to remove the majority (like 2/3), and I am talking only about internal links. I don't think it's a good idea to place all "bad" links into one issue, it's going to b hard to maintain and track. Same as creating 1 issue per URL isn't really helps (as it can shadow a number of documentation issues). What can be done I just dumping like 20 URLs per week, so people can work out what ware the issues with them, but honestly I don't see it happened if there like 1-2 people fixing links. I am going to keep tracking broken links and fix them, whenever I have time for that, and as a part of works under deadlinks project. |
@butuzov Sure. Thanks your advice. |
cool! |
For me there is several categories of broken links:
Among those broken links there are also two categories:
I would break this list of broken links into several categories. I think the trivially broken links can be done in bulk. |
@remyleone In the future, I will take your advice, classify the links in question, and then submit the PR separately for modification. Thanks! |
@tanjunchen I would love to help in the following. |
/assign |
@vishakhanihore welcome! |
@kubernetes/sig-docs-de-owners Is there a good solution for synchronizing this common resource (eg url)? |
Manually correcting the docs redirection is not a good idea IMO. There must be some bug or any error which is generating such wrong links @mrbobbytables @parispittman |
@butuzov hello,maybe you can see istio lint checker.there is external url checker? |
@tanjunchen I see |
@tanjunchen hi, |
@gorda Please update the wrong url according to merged pr above.Thanks |
aye |
@tanjunchen #18228 fix number six |
#18241 fix number 12 |
@CriaHu Thanks your job , i will update the above url once your pr are merged |
@xichengliudui during last merge more than hundred new deadlinks introduced to Chinese docs. |
@gorda Please update the wrong url according to merged pr above. We can sync every 7 days . Thanks |
/help |
Here are some pages with broken links (saved as a CSV format) |
@remyleone thank for your job! |
Done: #19513 |
@tanjunchen can I check the aim of this issue. I think the idea is to track every single broken link on the site? The reason I ask: if that's the case, I think there is too much work for this to qualify as a good first issue. However, this issue could be a great tracking issue from which to select single pages or single sections and create good-first-issue issues whenever the pool of open good first issues drops too low. |
Sure, the idea is to track every single broken link on the site. |
/remove-good-first-issue |
Problem:
some urls are wrong
Proposed Solution:
some urls need to be modified temporarily, some documents need to be updated, some outdated articles or urls are temporarily not modified.
Maybe not need to be modified under the content/en/blog/_posts/ folder
pr requirement:
comment your pr with
ref:https://github.com/kubernetes/website/issues/17649
,your pr will refer to this pr , so we can delete the urls.
Underlined indicates that it has been modified
content/en/blog/_posts 文件夹下:
The text was updated successfully, but these errors were encountered: