Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix links #18376

Merged
merged 1 commit into from
Jan 9, 2020
Merged

fix links #18376

merged 1 commit into from
Jan 9, 2020

Conversation

windayski
Copy link
Contributor

fix broken links

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 31, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @windayski!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 31, 2019
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 31, 2019
@windayski
Copy link
Contributor Author

/assign @zacharysarah

@xichengliudui
Copy link
Contributor

/lgtm
/approve
@windayski good job

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2020
markthink
markthink reviewed Jan 2, 2020
View reviewed changes
Copy link

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tanjunchen
Copy link
Member

ref:#17649

@markthink
Copy link

/lgtm
/approve

@tanjunchen
Copy link
Member

/cc @sftim
for en

@k8s-ci-robot k8s-ci-robot requested a review from sftim January 3, 2020 15:21
@sftim
Copy link
Contributor

sftim commented Jan 3, 2020

I'm not a blog reviewer. No objection to these changes though.
/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from sftim January 3, 2020 16:57
@bradtopol
Copy link
Contributor

Approving this as a PR wrangler since blog updates are only link updates

bradtopol
bradtopol reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@bradtopol bradtopol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. new links verified

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradtopol, markthink, xichengliudui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit a66b902 into kubernetes:master Jan 9, 2020
@tanjunchen
Copy link
Member

ref:#17649

wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@windayski @wawa0210
fix links (kubernetes#18376)
ae57974
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol bradtopol left review comments

@markthink markthink markthink left review comments

@cody-clark cody-clark Awaiting requested review from cody-clark

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@markthink markthink

@zacharysarah zacharysarah

@bradtopol bradtopol

@xichengliudui xichengliudui

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@windayski @k8s-ci-robot @xichengliudui @tanjunchen @markthink @sftim @bradtopol @zacharysarah