Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compute-device-assignment.md link #18289

Closed
wants to merge 3 commits into from
Closed

update compute-device-assignment.md link #18289

wants to merge 3 commits into from

Conversation

npu21
Copy link
Contributor

@npu21 npu21 commented Dec 24, 2019

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 24, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign makoscafee
You can assign the PR to them by writing /assign @makoscafee in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@npu21
Copy link
Contributor Author

npu21 commented Dec 24, 2019

assign @makoscafee
tks!

Copy link
Contributor

@mhamdisemah mhamdisemah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 26, 2019
@tanjunchen
Copy link
Member

/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim January 3, 2020 15:23
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npu21 I suggest also updating the text of the hyperlink. What do you think?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Ideally, @npu21, you would rebase these changes against master.
(you can see https://kubernetes.io/docs/contribute/intermediate/#work-from-a-local-clone for tips on doing that)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@npu21
Copy link
Contributor Author

npu21 commented Jan 9, 2020

/lgtm

Ideally, @npu21, you would rebase these changes against master.
(you can see https://kubernetes.io/docs/contribute/intermediate/#work-from-a-local-clone for tips on doing that)

Sure,will work from local clone. As you know, this is a large project and we need hacking and some walkaround to clone the nearly 200M files.

@sftim
Copy link
Contributor

sftim commented Jan 9, 2020

As you know, this is a large project and we need hacking and some walkaround to clone the nearly 200M files.

Hi; I hadn't known special steps are needed. Does the documentation about working locally need any tweak?

@tanjunchen
Copy link
Member

it is easy to rebase to one commit

@bradtopol
Copy link
Contributor

@sftim since you have been focused on this can you approve it when you feel its ready?
Thanks!

@sftim
Copy link
Contributor

sftim commented Jan 11, 2020

@npu21 if you rebase this, I'll be happy to re-/lgtm and approve it.

Running a rebase can be fiddly if it's a task you're not familiar with; if you'd like help getting up to speed on that, I can try to help.

@npu21
Copy link
Contributor Author

npu21 commented Jan 13, 2020

@sftim can I close this pr and open a new one, I'll update the .md in one commit, cause I've delete my local branch.
Anyway,thanks for your help!

@sftim
Copy link
Contributor

sftim commented Jan 18, 2020

If you want to get your local branch back @npu21:

# If necessary:
git add remote <name of remote for upstream> https://github.com/kubernetes/website

git fetch <name of remote for upstream> pull/18289/head:<name of new local branch>

@kbhawkey
Copy link
Contributor

Hello @npu21, Are you still working on this PR?

@jimangel
Copy link
Member

@npu21 I am closing this PR since there has been no activity since Feb 9th, Feel free to re-open after addressing feedback. Thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@jimangel: Closed this PR.

In response to this:

@npu21 I am closing this PR since there has been no activity since Feb 9th, Feel free to re-open after addressing feedback. Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants