-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update compute-device-assignment.md link #18289
Conversation
update compute-device-assignment.md link
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
assign @makoscafee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @sftim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@npu21 I suggest also updating the text of the hyperlink. What do you think?
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
…-gates.md Co-Authored-By: Tim Bannister <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ideally, @npu21, you would rebase these changes against master.
(you can see https://kubernetes.io/docs/contribute/intermediate/#work-from-a-local-clone for tips on doing that)
Sure,will work from local clone. As you know, this is a large project and we need hacking and some walkaround to clone the nearly 200M files. |
Hi; I hadn't known special steps are needed. Does the documentation about working locally need any tweak? |
it is easy to rebase to one commit |
@sftim since you have been focused on this can you approve it when you feel its ready? |
@npu21 if you rebase this, I'll be happy to re-/lgtm and approve it. Running a rebase can be fiddly if it's a task you're not familiar with; if you'd like help getting up to speed on that, I can try to help. |
@sftim can I close this pr and open a new one, I'll update the .md in one commit, cause I've delete my local branch. |
If you want to get your local branch back @npu21:
|
Hello @npu21, Are you still working on this PR? |
@npu21 I am closing this PR since there has been no activity since Feb 9th, Feel free to re-open after addressing feedback. Thanks! /close |
@jimangel: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#17649