Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 404 urls number six #18228

Closed
wants to merge 1 commit into from
Closed

fix 404 urls number six #18228

wants to merge 1 commit into from

Conversation

CriaHu
Copy link
Contributor

@CriaHu CriaHu commented Dec 21, 2019

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.

For pull requests on 1.17 Features: set Milestone to 1.17 and Base Branch to dev-1.17

For pull requests on Chinese localization, set Base Branch to release-1.16
Feel free to ask questions in #kubernetes-docs-zh

For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.<latest team milestone>

If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 21, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @CriaHu!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign onlydole
You can assign the PR to them by writing /assign @onlydole in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CriaHu
Copy link
Contributor Author

CriaHu commented Dec 21, 2019

#18228 fix number six

@CriaHu
Copy link
Contributor Author

CriaHu commented Dec 21, 2019

/assign @onlydole

@CriaHu CriaHu mentioned this pull request Dec 21, 2019
Closed
@onlydole
Copy link
Member

Thank you so much for this, @CriaHu

/lgtm
/assign @kbarnard10

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2019
@tanjunchen
Copy link
Member

ref:#17649

@tanjunchen
Copy link
Member

/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim January 3, 2020 15:22
sftim
sftim reviewed Jan 3, 2020
View reviewed changes
content/en/blog/_posts/2016-04-00-Building-Awesome-User-Interfaces-For-Kubernetes.md
@@ -19,7 +19,7 @@ SIG UI members have been independently working on a variety of UIs for Kubernete
| Dashboard UI v1.0 home screen showing applications running in a Kubernetes cluster. |


Since the initial release of the Dashboard UI we have been thinking hard about what to do next and what users of UIs for Kubernetes think about our plans. We’ve had many internal discussions on this topic, but most importantly, reached out directly to our users. We created a questionnaire asking a few demographic questions as well as questions for prioritizing use cases. We received more than 200 responses from a wide spectrum of user types, which in turn helped to shape the Dashboard UI’s [current roadmap](https://github.com/kubernetes/dashboard/blob/master/docs/devel/roadmap.md). Our members from LiveWyer summarised the results in a [nice infographic](http://static.lwy.io/img/kubernetes_dashboard_infographic.png).&nbsp;
Since the initial release of the Dashboard UI we have been thinking hard about what to do next and what users of UIs for Kubernetes think about our plans. We’ve had many internal discussions on this topic, but most importantly, reached out directly to our users. We created a questionnaire asking a few demographic questions as well as questions for prioritizing use cases. We received more than 200 responses from a wide spectrum of user types, which in turn helped to shape the Dashboard UI’s [current roadmap](https://github.com/kubernetes/dashboard/blob/master/docs/common/roadmap.md). Our members from LiveWyer summarised the results in a [nice infographic](http://static.lwy.io/img/kubernetes_dashboard_infographic.png).&nbsp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the roadmap is actually at https://github.com/kubernetes/dashboard/wiki/Roadmap

but it's an old blog post, it's OK for blog posts to have broken old links

(It's even cooler if the target URIs don't change).

Maybe it's better to link to https://github.com/kubernetes/dashboard/blob/4932fa7b50619849d2d68e55342925938e42e881/docs/devel/roadmap.md ? That's where the page pointed when the blog was written.

@tanjunchen
Copy link
Member

@CriaHu
update?

@kbarnard10
Copy link
Contributor

@CriaHu I'm going to close this for now since it's been hanging out here awhile. Please feel free to reopen when you have time to address the feedback. Thank you!

@kbarnard10 kbarnard10 closed this Feb 6, 2020
@CriaHu CriaHu deleted the test-master1 branch July 1, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@castrojo castrojo Awaiting requested review from castrojo

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

Assignees

@onlydole onlydole

@kbarnard10 kbarnard10

Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CriaHu @k8s-ci-robot @onlydole @tanjunchen @kbarnard10 @sftim