Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tanjunchen to sig-docs-zh team #2196

Merged
merged 2 commits into from
Sep 22, 2020
Merged

add tanjunchen to sig-docs-zh team #2196

merged 2 commits into from
Sep 22, 2020

Conversation

tanjunchen
Copy link
Member

@k8s-ci-robot k8s-ci-robot requested a review from tengqm September 18, 2020 14:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/github-management Issues or PRs related to GitHub Management subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 18, 2020
@tanjunchen
Copy link
Member Author

/assign @zacharysarah

@tengqm
Copy link
Contributor

tengqm commented Sep 18, 2020

LGTM
It would be great to have you in the team, @tanjunchen

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the persistent work!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2020
Copy link

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanjunchen One change, otherwise LGTM

@@ -342,6 +344,7 @@ teams:
- SataQiu # L10n: Chinese
- seokho-son # L10n: Korean
- sftim # L10n: English
- tanjunchen # L10n: Chinese

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line. Enough L10n team members have write access.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2020
@zacharysarah
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenrui333, tanjunchen, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 48ceba8 into kubernetes:master Sep 22, 2020
@tanjunchen tanjunchen deleted the add-tanjunchen-zh-member branch September 22, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants