-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tanjunchen to sig-docs-zh team #2196
add tanjunchen to sig-docs-zh team #2196
Conversation
/assign @zacharysarah |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for the persistent work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanjunchen One change, otherwise LGTM
@@ -342,6 +344,7 @@ teams: | |||
- SataQiu # L10n: Chinese | |||
- seokho-son # L10n: Korean | |||
- sftim # L10n: English | |||
- tanjunchen # L10n: Chinese |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this line. Enough L10n team members have write access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zacharysarah done.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenrui333, tanjunchen, zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I want to join the sig-docs-zh team:
I've become reviewer for zh docs.
I have worked for website for a long time.
So far, I have participated in website pr(460+) and issue (15+).
I hope I can have more permissions to make more contributions to the zh localization of the website.
https://github.com/kubernetes/website/pulls?q=is%3Apr+assignee%3Atanjunchen+is%3Aclosed 196
https://github.com/kubernetes/website/pulls?q=is%3Apr+author%3Atanjunchen+is%3Aclosed 106
https://github.com/kubernetes/website/pulls?q=is%3Apr+reviewed-by%3A%40me+ 132
https://github.com/kubernetes/website/issues?q=is%3Aopen+is%3Aissue++tanjunchen+ 16
such as https://github.com/kubernetes/website/issues/17649、https://github.com/kubernetes/website/issues/18411
/cc @tengqm