Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delete an 404 url #18345

Closed
wants to merge 1 commit into from
Closed

delete an 404 url #18345

wants to merge 1 commit into from

Conversation

huchengze
Copy link
Contributor

@huchengze huchengze commented Dec 28, 2019 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zacharysarah
You can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 28, 2019
@huchengze
Copy link
Contributor Author

/assign @zacharysarah

mhamdisemah
mhamdisemah reviewed Dec 30, 2019
View reviewed changes
Copy link
Contributor

@mhamdisemah mhamdisemah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change affects a lot of files in different languages, I think you should split it because a change can target only one language

@butuzov
Copy link
Contributor

butuzov commented Dec 30, 2019

@mhamdisemah not sure that there is a point for that (for korean - perhaps, but for others - no). Dependents content is deleted, what the point to have link to in in localizations?

@huchengze huchengze closed this Dec 31, 2019
@huchengze huchengze deleted the master-fix-links branch December 31, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhamdisemah mhamdisemah mhamdisemah left review comments

@cstoku cstoku Awaiting requested review from cstoku

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@zacharysarah zacharysarah

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huchengze @k8s-ci-robot @butuzov @mhamdisemah @zacharysarah