Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting invalid links #18094

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Correcting invalid links #18094

merged 1 commit into from
Dec 17, 2019

Conversation

yuxiaobo96
Copy link
Contributor

ref: #17649

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 12, 2019
@onlydole
Copy link
Member

Hello @yuxiaobo96, thank you for your contribution! Can I get your help in modifying only the portions of the page that need updates? Right now it's hard to review as most of the document has been changed.

onlydole
onlydole requested changes Dec 12, 2019
View reviewed changes
Copy link
Member

@onlydole onlydole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Please update so only the proper links are changed, and remove unnecessary deltas in the PR.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2019
@yuxiaobo96
Copy link
Contributor Author

@onlydole
Thank you for your advice, I have updated it.

@onlydole
Copy link
Member

Thank you, @yuxiaobo96!
/lgtm
/assign @mrbobbytables

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@mrbobbytables
Copy link
Member

/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6ef4d4c into kubernetes:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlydole onlydole onlydole requested changes

@vonguard vonguard Awaiting requested review from vonguard

Assignees

@onlydole onlydole

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuxiaobo96 @onlydole @mrbobbytables @k8s-ci-robot