Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken link : https://github.com/kubernetes/community/blob/master/contributors/devel/release.md #4248

Closed
wants to merge 0 commits into from
Closed

fix broken link : https://github.com/kubernetes/community/blob/master/contributors/devel/release.md #4248

wants to merge 0 commits into from

Conversation

CriaHu
Copy link
Contributor

@CriaHu CriaHu commented Nov 19, 2019

No description provided.

@k8s-ci-robot
Copy link
Contributor

Hi @CriaHu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2019
@k8s-ci-robot k8s-ci-robot added area/community-management sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 19, 2019
@CriaHu
Copy link
Contributor Author

CriaHu commented Nov 20, 2019

@vishakhanihore

@vishakhanihore
Copy link
Contributor

vishakhanihore commented Nov 20, 2019 via email

@CriaHu
Copy link
Contributor Author

CriaHu commented Nov 20, 2019

/assign @nikhita

@tanjunchen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2019
@tanjunchen
Copy link
Member

@CriaHu Can you help kk to fix broken urls?There are so many broken urls.Help.
ref:kubernetes/website#17649

@tanjunchen
Copy link
Member

tanjunchen commented Nov 20, 2019 •
edited
Loading

/lgtm
/assign @nikhita

@nikhita
Copy link
Member

nikhita commented Nov 20, 2019

Can you squash the commits into a single commit?

@CriaHu
Copy link
Contributor Author

CriaHu commented Nov 21, 2019

@tanjunchen ok, I'll try my best. I'll do it after I work.

@tanjunchen
Copy link
Member

@CriaHu squash five commits to one commit.

@CriaHu CriaHu closed this Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CriaHu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@tanjunchen
Copy link
Member

@CriaHu what is up?can you reopen this pr?

@vishakhanihore
Copy link
Contributor

vishakhanihore commented Nov 21, 2019 via email

@tanjunchen
Copy link
Member

@vishakhanihore get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CriaHu @k8s-ci-robot @vishakhanihore @tanjunchen @nikhita