Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement tasks for v1.6 release cycle #9104

Closed
23 of 35 tasks
furkatgofurov7 opened this issue Aug 2, 2023 · 29 comments
Closed
23 of 35 tasks

Improvement tasks for v1.6 release cycle #9104

furkatgofurov7 opened this issue Aug 2, 2023 · 29 comments
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Aug 2, 2023

NOTE: Issue is created based on #8418 to avoid ownership issues when there is a need for editing issue descriptions, assigning it to folks, etc. To check conversations in the previous cycle improvement tasks tracking issue, refer to #8418 (v1.5 release cycle) and #7524 (v1.4 release cycle).

NOTE2: The list of team-specific sub-tasks below are prioritized from highest priority sub-tasks to lowest from top to down accordingly, and priorities were agreed upon after triaging this issue collectively with the RT folks and repo maintainers. To see the notes from the triaging, please see: https://hackmd.io/@BcPM2Mr1SieWG3EZ0p5rGg/capi-improvement-tasks-v1-6

NOTE3: Each sub-task description has a GH handle next to it, meaning a sub-task is assigned to that person and he/she is actively working on it. If you would like to work on any unassigned sub-task feel free to comment on this umbrella issue 🙂

CI Signal/Bug Triage/Automation Manager Team sub-tasks

Communications/Docs/Release Notes Manager Team sub-tasks

Misc sub-tasks

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 2, 2023
@furkatgofurov7
Copy link
Member Author

/cc @kubernetes-sigs/cluster-api-release-team

@killianmuldoon
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 3, 2023
@furkatgofurov7
Copy link
Member Author

@killianmuldoon @sbueringer @joekr while the all improvements tasks polished up now, i have only one sub task without a clear understanding what needs to be done:

automate updates to specific versions of https://doc.crds.dev/github.com/kubernetes-sigs/cluster-api after release is cut

Do you have any idea what exactly needs to be done to accomplish ^ task?

@sbueringer
Copy link
Member

I can only guess, but I think doc.crds.dev only adds a new version to the list if someone calls it once. Probably after that it's also used as "latest". I think the links in our docs/book point to "latest", e.g. https://doc.crds.dev/github.com/kubernetes-sigs/cluster-api

@killianmuldoon
Copy link
Contributor

Yeah - if I remember right this link: https://doc.crds.dev/github.com/kubernetes-sigs/cluster-api@latest needs to be called at least once before it's cached as the base page for the repo.

The idea of that task was to automate that update - but it might be a good idea to initially add checking that page as a task during the release process. Automation can come after documented the manual process initially.

@sbueringer
Copy link
Member

sbueringer commented Aug 16, 2023

To be honest. I'm not sure if it's worth automating clicking a link if we do it once every 4 months. Maintaining automation also comes with a cost

@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Aug 16, 2023

I can only guess, but I think doc.crds.dev only adds a new version to the list if someone calls it once. Probably after that it's also used as "latest". I think the links in our docs/book point to "latest", e.g. https://doc.crds.dev/github.com/kubernetes-sigs/cluster-api

I do not know why, but when I click the above link, I have list of CRDs from v1.4.5, should we change it to point to latest?

@furkatgofurov7
Copy link
Member Author

The idea of that task was to automate that update - but it might be a good idea to initially add checking that page as a task during the release process. Automation can come after documented the manual process initially.

@killianmuldoon is it after the release is cut when we have to check it?

Also, talking to @joekr offline, got to know about this automation: https://github.com/oracle/cluster-api-provider-oci/blob/main/.github/workflows/release.yaml#L28-L31

Perhaps, we could also make use of it same way?

@sbueringer
Copy link
Member

sbueringer commented Aug 16, 2023

I do not why, but when I click the above link, I have list of CRDs from v1.4.5, should we change it to point to latest?

I get the same, I have no idea

@sbueringer
Copy link
Member

Perhaps, we could also make use of it same way?

Sounds okay as a very last step. I don't want to manually re-run stuff if this curl somehow fails

@killianmuldoon
Copy link
Contributor

@furkatgofurov7 can you assign me to Consider implementing a tool to generate our ProwJob YAMLs to make the jobs easier to manage

I'll open an issue to track it

@furkatgofurov7
Copy link
Member Author

@furkatgofurov7 can you assign me to Consider implementing a tool to generate our ProwJob YAMLs to make the jobs easier to manage

I'll open an issue to track it

Sure, assigned to you @killianmuldoon

@furkatgofurov7
Copy link
Member Author

@furkatgofurov7 can you assign me to Consider implementing a tool to generate our ProwJob YAMLs to make the jobs easier to manage

I'll open an issue to track it

@killianmuldoon did you have time to open a separate issue for this, if so, can you please point me to it?

@killianmuldoon
Copy link
Contributor

@furkatgofurov7 I've created and issue here: #9257

@cahillsf
Copy link
Member

@furkatgofurov7 can you add a task for ensuring the new 🚀 emoji passes the PR verify checks when you have a chance? example failed run

source code courtesy of Cecile (slack comment and src link)

related PR

@furkatgofurov7
Copy link
Member Author

@furkatgofurov7 can you add a task for ensuring the new 🚀 emoji passes the PR verify checks when you have a chance? example failed run

source code courtesy of Cecile (slack comment and src link)

related PR

Related issue: kubernetes-sigs/kubebuilder-release-tools#54

@cahillsf
Copy link
Member

👋 @furkatgofurov7 I can take this one:

Update documentation to build release notes tool from main before generating notes. We don't want to use go run anymore. Setup make target and ensuring the same binary is run on each release branch.

would be helpful if someone from comms team can provide a bit of context for why we are making this change as well

@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Oct 13, 2023

👋 @furkatgofurov7 I can take this one:

Update documentation to build release notes tool from main before generating notes. We don't want to use go run anymore. Setup make target and ensuring the same binary is run on each release branch.

would be helpful if someone from comms team can provide a bit of context for why we are making this change as well

Thanks @cahillsf, updated the issue with your name. @g-gaston was the idea here to build the tool once from main branch and use that for release branches without needing to regenerate it separately?

@cahillsf in any case, let's open a separate issue to track it and we can discuss the details over there

@cahillsf
Copy link
Member

👋 @furkatgofurov7 I can take this one too:

Ensure we have documentation on how to consume beta / RC releases (for users)

Although I need to understand this a bit better myself. I will miss the beta release cut tomorrow unfortunately but can watch the recording to catch up.

@furkatgofurov7
Copy link
Member Author

@cahillsf in any case, let's open a separate issue to track it and we can discuss the details over there

@cahillsf ^^^ 😄

@cahillsf
Copy link
Member

👋 hey @furkatgofurov7 all In Progress, To Do issues have been added to the v1.7 project board: https://github.com/orgs/kubernetes-sigs/projects/59

feel free to close out this issue

@furkatgofurov7
Copy link
Member Author

@cahillsf how about:

  • Improve the Netlify access model. Right now only limit people have access to the Netlify and for doing any thing regarding Netlify the people with access have to do some manual work. There is scope to improve this, either through more automation or more shared access
  • Clearly define the CI team's scope
  • Theoretically we can use k8s-triage to generate bug reports for flaky tests via "file bug" (link). Unfortunately the issues are always filed against k/k so we have to manually copy&paste the issue text to a Cluster API repo. Let's see if we can improve k8s-triage to be able to create issues in the Cluster API repo
  • Automate parts of the release notes that are "constant" through a minor release by reading from some file to populate the data. For example, the supported kubernetes versions can be maintained in a file on each release branch independently.
  • Format dependencies to exclude multiple bumps in the same set of release notes. For Go dependencies there's a discussion in this thread: https://kubernetes.slack.com/archives/C8TSNPY4T/p1686045243091189. For Github actions and other dependencies an alternative solution will have to be found.

they seem to be not in the GH board, which is obvious because you need either a separate issue or PR to add it to the board. Are you planning to create a separate issue in the repo and then add them to the board?
I am fine closing this issue out, just making sure we move over everything here to somewhere where we can track in the future.

@cahillsf
Copy link
Member

Ah right good catch - I only moved over the tasks with existing issues, will cut issues for the remainder to add to the new project board

@cahillsf
Copy link
Member

hey @furkatgofurov7 should be good here. the only one that i did not open as issue for is:

Consider adding expandable auto-generated release notes for beta and RC (non-GA) releases

will bring up for discussion in our kickoff RT meeting to see if we want to formalize this as an issue

@furkatgofurov7
Copy link
Member Author

hey @furkatgofurov7 should be good here. the only one that i did not open as issue for is:

Consider adding expandable auto-generated release notes for beta and RC (non-GA) releases

will bring up for discussion in our kickoff RT meeting to see if we want to formalize this as an issue

There is an existing issue for that already, so you can just track it: #9319

@furkatgofurov7
Copy link
Member Author

Looks like everything is covered now from this tracking issue, and all open/ongoing items have been carried over to GH board to be tracked, so closing this issue. Thanks @cahillsf!

/close

@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: Closing this issue.

In response to this:

Looks like everything is covered now from this tracking issue, and all open/ongoing items have been carried over to GH board to be tracked, so closing this issue. Thanks @cahillsf!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants