-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 hack: add weekly update script for Slack #9343
Conversation
abb751b
to
d4e6b73
Compare
caad7a0
to
4388102
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the weekly
tool be a subcommand of the release-notes
tool? I feel like this could become unwieldy and there's a duplication of effort. We might want another, similar, tool for emails for example.
I think that's a great idea actually. There does seem like a lot of duplicated code in the weekly script. I'll work on refactoring it into the notes script. |
4388102
to
471b382
Compare
faf38b5
to
a49b2d7
Compare
cc @kubernetes-sigs/cluster-api-release-team |
a49b2d7
to
8a2a340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! One comment inline:
/cc @killianmuldoon @sbueringer hey folks, could you please help reviewing this, since it is very helpful for comms team |
8a2a340
to
4c66913
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 8ca7f43f470b0895673a6491fa8854e643c65ff7
|
f7547ea
to
b312e79
Compare
b312e79
to
b86ed27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit from my side:
b86ed27
to
7ce977e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 34488ea25c824bb59aaf73680116346f64d09582
|
/test ? |
@furkatgofurov7: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks for this - good to see the quick evolution of the release tools this cycle!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@willie-yao: #9343 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@willie-yao: #9343 failed to apply on top of branch "release-1.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Like with the release notes tool it would be better IMO to only ever use this from main instead of trying to backport all changes. |
What this PR does / why we need it:
This is a new PR based mainly off of the work by @oscr in #8192
This PR adds a subcommand
weekly
to the existingnotes.go
command that generates the weekly updates that the comms team shares on Slack each week. This will make it simpler to create the messages and less chance of mistakes.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area release