-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add release tasks to update the GitHub actions to work with the new release #9488
Conversation
…elease Signed-off-by: Chirayu Kapoor <[email protected]>
@@ -163,6 +163,9 @@ From this point forward changes which should land in the release have to be cher | |||
2. Update the [milestone applier config](https://github.com/kubernetes/test-infra/blob/0b17ef5ffd6c7aa7d8ca1372d837acfb85f7bec6/config/prow/plugins.yaml#L371) accordingly (e.g. `release-1.4: v1.4` and `main: v1.5`) | |||
<br>Prior art: [cluster-api: update milestone applier config for v1.3](https://github.com/kubernetes/test-infra/pull/26631) | |||
|
|||
3. Update the GitHub Actions to work with the new release version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that this is covered in line ~452 under tasks for the CI lead with the creation of the other CI jobs.
Is the idea to make this part of the release lead tasks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@killianmuldoon I think this came up from the retrospective in the previous cycle and if I am not mistaken from you 😄 While you know better, the idea was to cover it so that we don't forget it in future releases and you had a patch (9115) that was mentioned in this PR. I was not aware it was already covered and don't see the point of making it part of RL tasks, so probably we can close it without merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the idea from the retro - if I remember right - was to put this in a checklist or some other easier to follow format - maybe something like the release issue, but broken down for the CI team so it's easier to follow.
I definitely missed this task when it should have been done during the last release cycle - 🤦 - and I think I probably added it to this file in the first place.
@killianmuldoon 👋🏼 is there anything that this PR is missing to take in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to approve if the release team thinks it's useful!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 46cb4a19fe0a0f34ca06aa70901c530fbb37aa82
|
Part of the Improvement tasks for the v1.6 release cycle #9104
What this PR does / why we need it:
Add release tasks to update the GitHub actions to work with the new release
Which issue(s) this PR fixes
Fixes #9486
/kind documentation
/area release