-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a method to CC Release Team on cherry-pick PRs to Releases #9212
Comments
/assign cahillsf |
/triage accepted |
posted in #sig-testing to see if the |
/triage accepted Thanks for looking into it! |
How does cc'ing the release team minimize the manual overhead in release maintenance? |
Well, maybe it is confusing to state "manual overhead in release maintenance" but rather "manual burden to PR author or maintainer to always cc RT in cherry pick PRs" |
I think I'm missing a crucial piece. Why do we want to either manually or automatically always cc the release team on all cherry-pick PRs? |
Correct me if I am wrong, Furkat, but I believe the intention here is not to always CC the release team on all the cherry-pick PRs, but provide a method to make it easier to CC RT on cherry-pick PRs where applicable |
Btw sorry for the stupid questions, I'm mostly trying to understand what workflow we're aiming for :) |
That came up in as one of the improvement tasks back from 1.4 RT. So basically, in case where we decide to cherry pick a PR and that needs RT's attention (don't ask me if that would be a case ever 😄) or at least they should be aware of it, then this automation would be used. Although, now I am thinking we might be complicating things to avoid one liner comment to tag a RT GH handle if considered needed. |
Yes, that is my understanding @cahillsf |
I think if we only want to cc the release team on some cherry-pick PRs it's probably easier to do it on those PRs vs trying to find a way to parameterize the cherry-pick. This can be also generalized to other folks and other PRs, aka if I want someones attention on a PR I just cc them (just joking a bit :)). Seems like we found out that we don't necessarily need to automate this (anymore). |
sounds good - seems like this is a "Won't Do". Closing out the issue |
What would you like to be added (User Story)?
As a release team member I would like to provide a way for cherry-pick PR authors to CC the release team on cherry-pick PRs where applicable to minimize manual burden on PR author or maintainer.
Detailed Description
CAPI Release team should be cc'ed on cherry-pick PRs to releases. Currently we see two paths forward:
prowAssignments
option (link)Anything else you would like to add?
No response
Label(s) to be applied
/kind feature
/area release
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.
The text was updated successfully, but these errors were encountered: