Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Clarify adding/removing release team members #9550

Merged

Conversation

furkatgofurov7
Copy link
Member

What this PR does / why we need it:
To not over-formalize the process but still have some information about expanding the team even during the release cycle to handle no-shows, this PR adds a lightweight note about adding/removing RT members to make it a bit clearer.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9273

/kind documentation
/area release

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/release Issues or PRs related to releasing labels Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect for what we need right now IMO.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cfc72154bdb0a52eab299a42067816e23a321484

@furkatgofurov7
Copy link
Member Author

@kubernetes-sigs/cluster-api-release-team

/cc @killianmuldoon @fabriziopandini @sbueringer

@furkatgofurov7 furkatgofurov7 force-pushed the expand-rt-handle-no-shows branch from e487f27 to fd64678 Compare October 13, 2023 11:18
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Oct 13, 2023

Looks perfect for what we need right now IMO.

/lgtm

Thanks @killianmuldoon, I realized that I missed to run doctoc in previous commit, now it should be fixed.

@g-gaston
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4053adfa7fa652495f1dde43d9f66afd2818f586

@furkatgofurov7
Copy link
Member Author

Thanks for reviews folks.

@vincepri looks like your review was not properly taken by prow, can you please re-approve it?

@killianmuldoon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit ef2a1df into kubernetes-sigs:main Oct 17, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Team: Consider expanding the team even during the release cycle to handle no-shows
5 participants