-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add onboarding documentation for the Release Team #9565
📖 Add onboarding documentation for the Release Team #9565
Conversation
@kubernetes-sigs/cluster-api-release-team /cc @killianmuldoon @fabriziopandini @CecileRobertMichon @chrischdi |
73d37cf
to
64c852c
Compare
Thanks @furkatgofurov7 |
LGTM label has been added. Git tree hash: 5de132946db4fe058a8eb3c702a191e62dfea635
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single nit,
we don't have that line in the other doctoc generated stuf.
As of that lgtm :-)
96faa68
to
016325c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits - thanks for adding this!
d5081aa
to
15f3ef9
Compare
@killianmuldoon @chrischdi thanks for reviews, PTAL once again when you have some spare time. |
Last couple of nits |
0d210f6
to
1514ee3
Compare
Edit: messed up the new commit, force pushed the old commit with suggested changes. |
fddb405
to
15f3ef9
Compare
Signed-off-by: Furkat Gofurov <[email protected]>
15f3ef9
to
e971c78
Compare
/test pull-cluster-api-test-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
Just in case you'd like a last round from the relevant teams.
Thanks!
LGTM label has been added. Git tree hash: f063cbd960b4f5ff94d8f088c9422efc7625a7ed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/lgtm |
/hold cancel |
Nice doc, thx! |
What this PR does / why we need it:
This PR adds an initial version of the release Team onboarding documentation which should serve as a starting point of the onboarding notes based on my experience being involved in the RT and can be evolved over time with more notes as the release team continues to serve in the future.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #9274
/area release
/kind documentation