-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure doc.crds.dev is updated on new release #9290
Comments
/assign cahillsf |
/triage accepted |
as a related issue, we have this issue with the docs page:
After further investigation, it appears that the default tag to be served if not provided in the URL params will be based on the For example Corresponds to the most recent push GH link: screenshot This means that in order to consistently serve the true latest tag as the default we will either need to:
|
I think ideally they should serve the latest release as latest (or the one with the highest semver) |
Thanks for digging into this, and finding out a reasoning behind it. I believe we can't always make sure backporting is done to the latest tag at last IMO, so ideally I would fall into the second option and try to update the logic in the |
/priority important-soon |
I see you found this issue as well Stefan. Seems unlikely that opening an issue to address this behavior will get prioritized. Also it looks like this option would not work anyway:
It seems that once the tag has been initially indexed, the I can take a shot at opening a PR to sort by semver tag, although it does seem like the future of this tool is uncertain. What do you think @sbueringer @furkatgofurov7 ? Looks like Joe went ahead and just added the CRD references to their book rather than relying on the tool, so maybe this is a better path to invest time in? |
I would probably continue to use docs.crds.dev if our only problem right now is the tag thing. We can always start generating the docs ourselves if it should go away. Not sure if we should move ahead of time. I prefer the way that docs.crds.dev renders it. |
I think giving a shot to change the current behavior in |
Repo maintainer is not responding on the improvement to the tags behavior (have a FR and a draft PR - opened 4 months ago and bumped with no reply). Going to close this out. |
Part of Improvement tasks for v1.6 release cycle #9104
There is discussion in the umbrella issue regarding whether automation is worth the maintenance effort. As a first step we will document that this link needs to be called after the release has been cut, and continue discussing tradeoffs for pursuing automation if needed.
latest
tag behavior when no tag is provided in the URL params/kind documentation
/area release
The text was updated successfully, but these errors were encountered: