Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkpoints model and file system watcher #3684

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Apr 14, 2023

2/2 main <- #3665 <- this

This PR accounts for a couple of the TODO items in #3665. Namely

  • Drop full vs partial exp show updates
  • Delete hasCheckpoints/checkpoints watcher and use {data: {meta: hasCheckpoints}}

@mattseddon mattseddon force-pushed the update-exp-fs-watchers branch from f312a6a to cd43a2d Compare April 17, 2023 01:36
@mattseddon mattseddon marked this pull request as ready for review April 17, 2023 05:01
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattseddon mattseddon merged commit 269840a into integrate-exp-show Apr 17, 2023
@mattseddon mattseddon deleted the update-exp-fs-watchers branch April 17, 2023 22:36
mattseddon added a commit that referenced this pull request Apr 20, 2023
…outside the workspace) (#3665)

* wrap all loose test data in test data generator

* add new type

* duplicate required functions but use new data

* update test fixtures

* deduplicate functions

* remove checkpoints model and file system watcher (#3684)

* extend timeout of run experiment test (e2e) (#3713)

* prevent plotting of running experiments (#3712)

* trigger plot updates whenever commit data changes (#3715)

* update demo project and min required version of DVC

* fix experiment id for commits (shown in plots) (#3724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants