-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove checkpoints model and file system watcher #3684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
integrate-exp-show
branch
from
April 14, 2023 06:26
993f67e
to
27dbd15
Compare
mattseddon
force-pushed
the
update-exp-fs-watchers
branch
from
April 14, 2023 06:26
e40b4dd
to
7116489
Compare
mattseddon
force-pushed
the
integrate-exp-show
branch
from
April 17, 2023 01:35
27dbd15
to
54eedd9
Compare
mattseddon
force-pushed
the
update-exp-fs-watchers
branch
from
April 17, 2023 01:35
7116489
to
f312a6a
Compare
mattseddon
force-pushed
the
update-exp-fs-watchers
branch
from
April 17, 2023 01:36
f312a6a
to
cd43a2d
Compare
sroy3
approved these changes
Apr 17, 2023
julieg18
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This was referenced Apr 17, 2023
mattseddon
added a commit
that referenced
this pull request
Apr 20, 2023
…outside the workspace) (#3665) * wrap all loose test data in test data generator * add new type * duplicate required functions but use new data * update test fixtures * deduplicate functions * remove checkpoints model and file system watcher (#3684) * extend timeout of run experiment test (e2e) (#3713) * prevent plotting of running experiments (#3712) * trigger plot updates whenever commit data changes (#3715) * update demo project and min required version of DVC * fix experiment id for commits (shown in plots) (#3724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/2
main
<- #3665 <- thisThis PR accounts for a couple of the TODO items in #3665. Namely
exp show
updateshasCheckpoints
/checkpoints
watcher and use {data: {meta: hasCheckpoints}}